Bug 105015

Summary: [SOUP] Showing blank page when reload is pressed after login to twitter.com
Product: WebKit Reporter: Raveendra Karu <r.karu>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: basavaraj.ps, bugs-noreply, danw, gustavo, keunsoon.lee, laszlo.gombos, mrobinson, rakuco, webkit.review.bot
Priority: P2 Keywords: Soup
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch none

Raveendra Karu
Reported 2012-12-14 05:43:13 PST
[SOUP] Showing blank page when reload is pressed after login to twitter.com
Attachments
Patch (1.96 KB, patch)
2012-12-14 05:55 PST, Raveendra Karu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raveendra Karu
Comment 1 2012-12-14 05:55:20 PST
Created attachment 179471 [details] Patch
Martin Robinson
Comment 2 2012-12-14 06:22:26 PST
Maybe Dan can do an informal review here?
Dan Winship
Comment 3 2012-12-14 13:14:22 PST
The logic is correct, although libsoup also does this internally, so the fact that we need it suggests some sort of failure in the SoupMessage<->ResourceRequest syncing code... (This will also be obsoleted by my upcoming redirection-handling rewrite, but that doesn't mean this fix can't be committed now...)
Gustavo Noronha (kov)
Comment 4 2012-12-23 06:12:10 PST
I think we just need an else block zeroing the request body here: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp#L106 if (soupMessage->request_body->data) m_httpBody = FormData::create(soupMessage->request_body->data, soupMessage->request_body->length); else setHttpBody(0);
Dan Winship
Comment 5 2013-01-11 07:32:05 PST
Comment on attachment 179471 [details] Patch This will no longer apply after the changes from bug 88961. I'm not sure if the bug still exists or not though.
Note You need to log in before you can comment on or make changes to this bug.