Bug 104995

Summary: [Shadow DOM]: ShadowRoot wrong nodeName attribute
Product: WebKit Reporter: Sergey G. Grekhov <sgrekhov>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gyuyoung.kim, ojan.autocc, ossy, rakuco, rniwa, shinyak, simon.fraser, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88748    
Bug Blocks: 63606, 103230    
Attachments:
Description Flags
Patch
none
Patch none

Sergey G. Grekhov
Reported 2012-12-13 23:49:02 PST
According Shadow DOM specification (https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes) "Accordingly, the nodeName attribute of a ShadowRoot instance must return "#document-fragment".". But in Chrome 23.0.1271.97 m ShadowRoot nodeName is "#shadow-root". Test: <html> <head> <script> function test() { var SR = window.ShadowRoot || window.WebKitShadowRoot; var host = document.createElement('div'); document.body.appendChild(host); var s = new SR(host); alert(s.nodeName); } </script> </head> <body onload='test()'> </body> </html>
Attachments
Patch (82.59 KB, patch)
2012-12-20 21:56 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (406.19 KB, patch)
2013-01-09 00:08 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-12-20 21:56:44 PST
Created attachment 180481 [details] Patch
Shinya Kawanaka
Comment 2 2012-12-20 21:57:37 PST
If a bot became red, maybe I have missed some rebaselineing. Let's see it.
Ryosuke Niwa
Comment 3 2012-12-21 01:19:07 PST
(In reply to comment #2) > If a bot became red, maybe I have missed some rebaselineing. Let's see it. Why don't you grep them instead of manually rebaselining them? We know that all instances of "#shadow-root" should simply be replaced by "#document-fragment", right?
WebKit Review Bot
Comment 4 2012-12-21 07:46:00 PST
Comment on attachment 180481 [details] Patch Clearing flags on attachment: 180481 Committed r138376: <http://trac.webkit.org/changeset/138376>
WebKit Review Bot
Comment 5 2012-12-21 07:46:03 PST
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 6 2012-12-21 09:33:09 PST
This broke about 60 tests on Mac: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r138378%20(5188)/results.html
Dimitri Glazkov (Google)
Comment 7 2012-12-21 09:41:52 PST
(In reply to comment #6) > This broke about 60 tests on Mac: > http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r138378%20(5188)/results.html :-( rolling out...
Dimitri Glazkov (Google)
Comment 8 2012-12-21 09:43:36 PST
Reverted r138376 for reason: Broke a bunch of tests on mac. Committed r138386: <http://trac.webkit.org/changeset/138386>
Ryosuke Niwa
Comment 9 2012-12-21 10:33:11 PST
(In reply to comment #7) > (In reply to comment #6) > > This broke about 60 tests on Mac: > > http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r138378%20(5188)/results.html > > :-( rolling out... Don’t we need to just rebaseline them all?
Ryosuke Niwa
Comment 10 2012-12-21 10:34:06 PST
This is why I said that you should just run grep in comment #3 so that you can rebaseline all expected results for all platforms.
Csaba Osztrogonác
Comment 11 2012-12-21 11:11:37 PST
This patch broke tests on Qt too - http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r138379%20%2846257%29/results.html
Shinya Kawanaka
Comment 12 2012-12-24 17:14:52 PST
Oops... Very sorry... Ryosuke, you are very right. Dimitry, sorry for bothering you. I'll check all the tests again. Also I have to have some method to check the Node is ShadowRoot in the port where SHADOW_DOM flag is not enabled. Maybe internals?
Shinya Kawanaka
Comment 13 2013-01-09 00:08:05 PST
Created attachment 181866 [details] Patch
Dimitri Glazkov (Google)
Comment 14 2013-01-09 09:18:49 PST
I wonder if having #document-fragment in all those test results will just be more confusing. The person looking at the test must make a mental jump to "oh, that's shadow root". Maybe we should present it differently (although that's also problematic, because we're special-casing shadow roots)?
WebKit Review Bot
Comment 15 2013-01-09 09:36:20 PST
Comment on attachment 181866 [details] Patch Clearing flags on attachment: 181866 Committed r139198: <http://trac.webkit.org/changeset/139198>
WebKit Review Bot
Comment 16 2013-01-09 09:36:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.