Bug 104987

Summary: MediaPlayerPrivateAVFoundation::m_inbandTrackConfigurationPending is unused except when HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT)
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: MediaAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: jberlin, msaboff, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
the patch none

Filip Pizlo
Reported 2012-12-13 19:54:00 PST
We should conditionally declare and assign it behind the HAVE() guard.
Attachments
the patch (2.23 KB, patch)
2012-12-13 19:55 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-12-13 19:55:20 PST
Created attachment 179404 [details] the patch
Filip Pizlo
Comment 2 2012-12-13 19:55:36 PST
Using cq instead of landing manually because I'm hoping for some additional test coverage on this.
WebKit Review Bot
Comment 3 2012-12-13 20:39:22 PST
Comment on attachment 179404 [details] the patch Clearing flags on attachment: 179404 Committed r137707: <http://trac.webkit.org/changeset/137707>
WebKit Review Bot
Comment 4 2012-12-13 20:39:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.