Bug 104973

Summary: [chromium] Remove unnecessary compile guards in WebContentLayerClient.h
Product: WebKit Reporter: Alok Priyadarshi <alokp>
Component: Layout and RenderingAssignee: Alok Priyadarshi <alokp>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, dglazkov, enne, fishd, jamesr, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch enne: review+, webkit.review.bot: commit-queue-

Alok Priyadarshi
Reported 2012-12-13 16:21:19 PST
WEBCONTENTLAYERCLIENT_HAS_OPAQUE WEBCONTENTLAYERCLIENT_FLOAT_OPAQUE_RECT WEBCONTENTLAYERCLIENT_HAS_CANPAINTLCDTEXT These are not needed anymore. Chromium patch to remove the dependency on WEBCONTENTLAYERCLIENT_HAS_CANPAINTLCDTEXT is in CQ.
Attachments
Patch (1.73 KB, patch)
2012-12-13 16:25 PST, Alok Priyadarshi 		enne: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alok Priyadarshi
Comment 1 2012-12-13 16:25:10 PST
Created attachment 179370 [details] Patch
Adrienne Walker
Comment 2 2012-12-13 16:26:42 PST
Comment on attachment 179370 [details] Patch R=me.
WebKit Review Bot
Comment 3 2012-12-13 16:26:44 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 4 2012-12-13 16:33:46 PST
Comment on attachment 179370 [details] Patch Attachment 179370 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15311467
Peter Beverloo (cr-android ews)
Comment 5 2012-12-13 17:47:06 PST
Comment on attachment 179370 [details] Patch Attachment 179370 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15322437
James Robinson
Comment 6 2012-12-13 20:05:21 PST
You need to roll the chromium patch into Source/WebKit/chromium/DEPS before this can land safely.
Alok Priyadarshi
Comment 7 2012-12-14 10:47:40 PST
(In reply to comment #6) > You need to roll the chromium patch into Source/WebKit/chromium/DEPS before this can land safely. All references to WEBCONTENTLAYERCLIENT_HAS_CANPAINTLCDTEXT in chromium were deleted in chromium r173101. Chromium rev in WebKit has been rolled to 173133. OK to commit?
Alok Priyadarshi
Comment 8 2013-01-03 10:37:41 PST
ping!
Adrienne Walker
Comment 9 2013-01-03 10:42:51 PST
(In reply to comment #8) > ping! You're the committer here. :) Go ahead and CQ it or put up another patch for EWS if you're feeling more paranoid.
Alok Priyadarshi
Comment 10 2013-01-03 10:45:13 PST
Comment on attachment 179370 [details] Patch I thought I had to wait for fishd/jamesr. Adding to CQ.
WebKit Review Bot
Comment 11 2013-01-03 10:46:54 PST
Comment on attachment 179370 [details] Patch Rejecting attachment 179370 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/Platform/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/Platform/chromium/public/WebContentLayerClient.h Hunk #1 FAILED at 41. 1 out of 1 hunk FAILED -- saving rejects to file Source/Platform/chromium/public/WebContentLayerClient.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adrienne W..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15665159
Alok Priyadarshi
Comment 12 2013-01-03 11:02:37 PST
jamesr already committed an equivalent patch in r138687. *** This bug has been marked as a duplicate of bug 105971 ***
Note You need to log in before you can comment on or make changes to this bug.