Bug 104942
| Summary: | REGRESSION: Two recent compositing/background-color tests always fail on Mac | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bdakin, noam, rniwa, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 104842 | ||
| Bug Blocks: | |||
Beth Dakin
These two tests always fail on Mac:
compositing/background-color/background-color-text-change.html
compositing/background-color/background-color-change-to-text.html
They were added with http://trac.webkit.org/changeset/137051 It is worth noting that they seem to pass in Safari 6, but they are failing on TOT.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Beth Dakin
Links to the tests:
http://trac.webkit.org/export/137619/trunk/LayoutTests/compositing/background-color/background-color-change-to-text.html
http://trac.webkit.org/export/137619/trunk/LayoutTests/compositing/background-color/background-color-text-change.html
Beth Dakin
http://trac.webkit.org/changeset/137051 , the very revision that checked these tests in is what caused them to start failing on the Mac! I will skip these tests for now, but we will have to fix this regression.
Beth Dakin
Bizarrely, when I run these tests on my own computer, they do not fail. However, they do fail when I open them manually and they fail on the bots. Not quite sure what to make of that.
Beth Dakin
Okay, I skipped the tests for now with http://trac.webkit.org/changeset/137648 (and http://trac.webkit.org/changeset/137649 to fix the copy-paste error).
Noam Rosenthal
(In reply to comment #3)
> Bizarrely, when I run these tests on my own computer, they do not fail. However, they do fail when I open them manually and they fail on the bots. Not quite sure what to make of that.
Yes, I've experienced that same thing. It's probably what had me thrown off when I landed this, though I don't remember the particulars.
Simon Fraser (smfr)
Pretty sure bug 104842 is going to fix these.
Beth Dakin
Thanks, Simon!
http://trac.webkit.org/changeset/137690
Beth Dakin
(In reply to comment #7)
> Thanks, Simon!
>
> http://trac.webkit.org/changeset/137690
Ignore this!! wrong bug.
Ryosuke Niwa
Removed the test expectations in http://trac.webkit.org/changeset/138734 since the test has been passing.