Bug 104855

Summary: Block level pseudo elements bleed background color to <html>
Product: WebKit Reporter: Elliott Sprehn <esprehn>
Component: New BugsAssignee: Elliott Sprehn <esprehn>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, jchaffraix, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Elliott Sprehn
Reported 2012-12-12 15:39:24 PST
Block level pseudo elements bleed background color to <html>
Attachments
Patch (2.54 KB, patch)
2012-12-12 15:55 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2012-12-19 21:03 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2012-12-12 15:55:28 PST
Created attachment 179138 [details] Patch
WebKit Review Bot
Comment 2 2012-12-12 17:17:39 PST
Comment on attachment 179138 [details] Patch Attachment 179138 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15317012 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Elliott Sprehn
Comment 3 2012-12-12 17:48:50 PST
(In reply to comment #2) > (From update of attachment 179138 [details]) > Attachment 179138 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15317012 > > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html This is definitely not related, seeing as this patch only contains tests. :)
Julien Chaffraix
Comment 4 2012-12-13 13:18:04 PST
Comment on attachment 179138 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179138&action=review > LayoutTests/ChangeLog:21 > + This was reported as a Chromium Bug: > + https://code.google.com/p/chromium/issues/detail?id=75544 We usually don't put downstream bug here as they have little signification in WebKit. > LayoutTests/ChangeLog:23 > + Extra space. > LayoutTests/fast/css-generated-content/html-pseudo-background-color.html:8 > + } I think you should also check for html:after. Either in this test (with a different color and the condition for passing would be "there should be no background color" or another one. > LayoutTests/fast/css-generated-content/html-pseudo-background-color.html:11 > +<p> Your bug should say what it tests (ie include a description). Without the ChangeLog, it is difficult to see what could go wrong. Including the bug number and title is also nice.
Elliott Sprehn
Comment 5 2012-12-19 20:49:03 PST
(In reply to comment #4) > (From update of attachment 179138 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179138&action=review > ... > > Your bug should say what it tests (ie include a description). Without the ChangeLog, it is difficult to see what could go wrong. So to explain what this bug is about: RenderObject::isRoot checks if document()->documentElement() == m_node and in the old generated content implementation m_node was set to the generatingNode so for html:before or html:after so isRoot() would return true. This meant that when we go through RenderBox::paintBackground we would end up painting the generated content's background color over the whole document. This is fixed by the new generated content implementation that was turned on in r137336 because m_node is now the PseudoElement, not the <html> element.
Elliott Sprehn
Comment 6 2012-12-19 21:03:54 PST
Created attachment 180271 [details] Patch
WebKit Review Bot
Comment 7 2012-12-20 10:49:49 PST
Comment on attachment 180271 [details] Patch Clearing flags on attachment: 180271 Committed r138274: <http://trac.webkit.org/changeset/138274>
WebKit Review Bot
Comment 8 2012-12-20 10:49:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.