Bug 104852

Summary:

GraphicsLayer::supportsBackgroundColorContent() should include Apple Windows

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

noam, roger_fong, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	simon.fraser: review+

Description Simon Fraser (smfr) 2012-12-12 15:07:57 PST

static bool supportsBackgroundColorContent()
    {
#if PLATFORM(MAC) || USE(TEXTURE_MAPPER)
        return true;
#else
        return false;
#endif
    }

We want this on for Apple windows too.

Comment 1 Simon Fraser (smfr) 2012-12-12 15:12:18 PST

USE(CA) might be the right thing to use instead of PLATFORM(MAC)

Comment 2 Roger Fong 2012-12-12 15:59:04 PST

USE(CA) does indeed appear to work...

Comment 3 Roger Fong 2012-12-12 17:32:53 PST

Created attachment 179159 [details]
patch

Comment 4 Roger Fong 2012-12-12 17:44:52 PST

actually, any tests i should be enabling now?

Comment 5 Simon Fraser (smfr) 2012-12-12 18:16:38 PST

Comment on attachment 179159 [details]
patch

There are a bunch of ref tests in compositing/background-color.

Comment 6 Roger Fong 2012-12-12 18:27:22 PST

(In reply to comment #5)
> (From update of attachment 179159 [details])
> There are a bunch of ref tests in compositing/background-color.

Alas, guess not then, silly ref tests.

Comment 7 Roger Fong 2012-12-12 18:37:03 PST

http://trac.webkit.org/changeset/137557