Bug 104852

Summary: GraphicsLayer::supportsBackgroundColorContent() should include Apple Windows
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: noam, roger_fong, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Simon Fraser (smfr)
Reported 2012-12-12 15:07:57 PST
static bool supportsBackgroundColorContent() { #if PLATFORM(MAC) || USE(TEXTURE_MAPPER) return true; #else return false; #endif } We want this on for Apple windows too.
Attachments
patch (1.14 KB, patch)
2012-12-12 17:32 PST, Roger Fong 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-12-12 15:12:18 PST
USE(CA) might be the right thing to use instead of PLATFORM(MAC)
Roger Fong
Comment 2 2012-12-12 15:59:04 PST
USE(CA) does indeed appear to work...
Roger Fong
Comment 3 2012-12-12 17:32:53 PST
Created attachment 179159 [details] patch
Roger Fong
Comment 4 2012-12-12 17:44:52 PST
actually, any tests i should be enabling now?
Simon Fraser (smfr)
Comment 5 2012-12-12 18:16:38 PST
Comment on attachment 179159 [details] patch There are a bunch of ref tests in compositing/background-color.
Roger Fong
Comment 6 2012-12-12 18:27:22 PST
(In reply to comment #5) > (From update of attachment 179159 [details]) > There are a bunch of ref tests in compositing/background-color. Alas, guess not then, silly ref tests.
Roger Fong
Comment 7 2012-12-12 18:37:03 PST
http://trac.webkit.org/changeset/137557
Note You need to log in before you can comment on or make changes to this bug.