Bug 104831

Summary: [chromium] don't write additional idl files to a gyp temp file
Product: WebKit Reporter: Tony Chang <tony>
Component: Tools / TestsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104740    
Attachments:
Description Flags
Patch none

Tony Chang
Reported 2012-12-12 12:08:26 PST
During binding generation, we current write additional_idl_files_list with some special syntax. This will cause a problem for bug 104740 because we're going to generate an idl file, but <|( in gyp isn't able to handle build system variables. For example, if you try to write the file <(PRODUCT_DIR)/foo to a file using <|(, you end up with $!PRODUCT_DIR/foo or $(OutDir) in the file. We can work around this problem by not using <|( for additional_idl_files.
Attachments
Patch (5.11 KB, patch)
2012-12-12 12:27 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-12-12 12:27:36 PST
Created attachment 179103 [details] Patch
Kentaro Hara
Comment 2 2012-12-12 14:08:57 PST
Comment on attachment 179103 [details] Patch Looks good to me.
WebKit Review Bot
Comment 3 2012-12-12 15:02:08 PST
Comment on attachment 179103 [details] Patch Clearing flags on attachment: 179103 Committed r137519: <http://trac.webkit.org/changeset/137519>
WebKit Review Bot
Comment 4 2012-12-12 15:02:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.