Bug 104825
| Summary: | calendar-picker tests have image diffs on cr-mac after r137473 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Klein <adamk> |
| Component: | Tools / Tests | Assignee: | Justin Novosad <junov> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | junov, keishi, simon.fraser, tkent |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adam Klein
See flakiness dashboard for detailed failures:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-ru.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fweek-picker-appearance.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-step.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fweek-picker-appearance-step.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fmonth-picker-appearance.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance.html%2Cplatform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fmonth-picker-appearance-step.html
There are minor image diffs in the next/prev month buttons. The dashboard points pretty definitively at http://trac.webkit.org/changeset/137473 as the culprit. I think it's likely these just need rebaselining, but I'd like the interested parties to take a look before I go ahead and do that.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Justin Novosad
Yep, I'll rebase these along with the related temporary suppressions.
Justin Novosad
Rebaselined with
http://trac.webkit.org/changeset/137503