Bug 104800 – Layout Test inspector-protocol/take-heap-snapshot.html crashes in the Debug mode

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kentaro Hara]

The following layout test is failing on the Debug mode in all platforms

inspector-protocol/take-heap-snapshot.html

Probable cause:

crash log for DumpRenderTree (pid 17694):
STDOUT: <empty>
STDERR: 
STDERR: 
STDERR: #
STDERR: # Fatal error in v8/src/heap-inl.h, line 189
STDERR: # CHECK(allocation_allowed_ && gc_state_ == NOT_IN_GC) failed
STDERR: #
STDERR: 

For now, I'll mark the test as CRASH. Please investigate.

[Yury Semikhatsky]

*** Bug 104801 has been marked as a duplicate of this bug. ***

[Yury Semikhatsky]

Related issue: https://code.google.com/p/v8/issues/detail?id=2515

[Yury Semikhatsky]

Created attachment 185699 [details]
Patch

[Yury Semikhatsky]

Marja, can you confirm that disabling Profiler.reportHeapSnapshotProgress events by default doesn't break your tools?

[Ilya Tikhonovsky]

Comment on attachment 185699 [details]
Patch

lgtm

Comment on attachment 185699 [details]
Patch

Since the parameter is optional, and the default behavior is the old behavior, there shouldn't be a problem.

thx for the heads up

[Yury Semikhatsky]

(In reply to comment #6)
> (From update of attachment 185699 [details])
> Since the parameter is optional, and the default behavior is the old behavior, there shouldn't be a problem.
> 
> thx for the heads up

Actually the behavior changed compared to the old one: we used to send the events by default but after the change they will only be sent if the flag is true. That's why I'm asking. I didn't want to add doNotReportProgress optional flag as we normally prefer features opted out by default and here it would be an opposite meaning.

(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 185699 [details] [details])
> > Since the parameter is optional, and the default behavior is the old behavior, there shouldn't be a problem.
> > 
> > thx for the heads up
> 
> Actually the behavior changed compared to the old one: we used to send the events by default but after the change they will only be sent if the flag is true. That's why I'm asking. I didn't want to add doNotReportProgress optional flag as we normally prefer features opted out by default and here it would be an opposite meaning.

Thanks for clarifying.

However, we don't depend on that feature in any way, so please go ahead!

[Yury Semikhatsky]

Committed r141388: <http://trac.webkit.org/changeset/141388>