Summary: | Layout Test inspector-protocol/take-heap-snapshot.html crashes in the Debug mode | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
Component: | Tools / Tests | Assignee: | Yury Semikhatsky <yurys> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alph, jochen, loislo, marja, pfeldman, vsevik, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Kentaro Hara
2012-12-12 05:28:01 PST
*** Bug 104801 has been marked as a duplicate of this bug. *** Related issue: https://code.google.com/p/v8/issues/detail?id=2515 Created attachment 185699 [details]
Patch
Marja, can you confirm that disabling Profiler.reportHeapSnapshotProgress events by default doesn't break your tools? Comment on attachment 185699 [details]
Patch
lgtm
Comment on attachment 185699 [details]
Patch
Since the parameter is optional, and the default behavior is the old behavior, there shouldn't be a problem.
thx for the heads up
(In reply to comment #6) > (From update of attachment 185699 [details]) > Since the parameter is optional, and the default behavior is the old behavior, there shouldn't be a problem. > > thx for the heads up Actually the behavior changed compared to the old one: we used to send the events by default but after the change they will only be sent if the flag is true. That's why I'm asking. I didn't want to add doNotReportProgress optional flag as we normally prefer features opted out by default and here it would be an opposite meaning. (In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 185699 [details] [details]) > > Since the parameter is optional, and the default behavior is the old behavior, there shouldn't be a problem. > > > > thx for the heads up > > Actually the behavior changed compared to the old one: we used to send the events by default but after the change they will only be sent if the flag is true. That's why I'm asking. I didn't want to add doNotReportProgress optional flag as we normally prefer features opted out by default and here it would be an opposite meaning. Thanks for clarifying. However, we don't depend on that feature in any way, so please go ahead! Committed r141388: <http://trac.webkit.org/changeset/141388> |