Bug 104789

Summary: [GTK] The GTK EWS bots should run the unit tests
Product: WebKit Reporter: Zan Dobersek <zan>
Component: Tools / TestsAssignee: Zan Dobersek <zan>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: abarth, bugs-noreply, cgarcia, clopez, dpranke, gustavo, lmoura, mrobinson, pnormand, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2012-12-12 02:42:07 PST
The GTK port maintainers would like to run the unit tests on the EWS bots, but not the layout tests. The current RunTests step does not allow for that, so there are other changes required rather than just marking the GTK EWS as running the tests by default.
Attachments
Patch (5.98 KB, patch)
2012-12-12 03:29 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (7.04 KB, patch)
2012-12-15 04:54 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-12-12 03:29:30 PST
Created attachment 179015 [details] Patch
Dirk Pranke
Comment 2 2012-12-12 10:38:52 PST
Comment on attachment 179015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179015&action=review > Tools/Scripts/webkitpy/tool/steps/runtests.py:50 > + return self._tool.port().port_flag_name is not "gtk" Seems like this should be a method on the port object?
Zan Dobersek
Comment 3 2012-12-15 04:54:06 PST
Created attachment 179588 [details] Patch
Zan Dobersek
Comment 4 2012-12-16 00:07:38 PST
Comment on attachment 179588 [details] Patch The patch is still incorrect, it doesn't work due to the the necessary output format being unsupported by run-gtk-tests.
Martin Robinson
Comment 5 2015-05-07 19:22:32 PDT
I would love to see this happen! Any updates?
Lauro Moura
Comment 6 2020-06-25 15:10:44 PDT
bug202361 added support for running `run-gtk-tests` in the EWS bots as buildAndTest, followed by bug208860 which made them testOnly. Closing.
Note You need to log in before you can comment on or make changes to this bug.