Bug 104787 – [EFL][GTK] spelling-unified-emulation.html fails - word "zzz" cannot be found by enchant

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Grzegorz Czajkowski]

Hi,

There is another test which fails for both EFL and GTK+ WebKit ports.
This est has been added in bug 70299, it allows legacy text check emulation in unified text check interface.

It fails due to word "zzz" which cannot be found by enchant library, checked for en_US dictionary, see result of command: echo "zzz" | enchant -l
Can we replace the problematic sound of snoring with a different phrase? That change will allow to test unified text checking by EFL and GTK+ WebKit ports.

I will upload patch as soon as I get your opinions.
Thanks

[Mario Sanchez Prada]

(In reply to comment #0)
> Hi,
> 
> There is another test which fails for both EFL and GTK+ WebKit ports.
> This est has been added in bug 70299, it allows legacy text check emulation in unified text check interface.
> 
> It fails due to word "zzz" which cannot be found by enchant library, checked for en_US dictionary, see result of command: echo "zzz" | enchant -l
> Can we replace the problematic sound of snoring with a different phrase? That change will allow to test unified text checking by EFL and GTK+ WebKit ports.

I'm not 100% sure about how they used this 'zzz' string but I guess it could be to test the following situation:

  "a test case containing a valid word which contains a bad word as a substring"

...assuming that 'zz' is expected to be invalid while 'zzz' should be valid.

If that's the case, and after checking that indeed 'zzz' is not considered valid by enchant with a en_US dictionary, I think there shouldn't be any big issue in changing that string with something different. Perhaps the words 'buzz' or 'buzzer' might be valid in case we don't want to change the 'zz' lines. 

> I will upload patch as soon as I get your opinions.

I think it doesn't hurts to change this as long as the same kind of situations keep being tested

[Grzegorz Czajkowski]

(In reply to comment #1)
> (In reply to comment #0)
> > Hi,
> > 
> > There is another test which fails for both EFL and GTK+ WebKit ports.
> > This est has been added in bug 70299, it allows legacy text check emulation in unified text check interface.
> > 
> > It fails due to word "zzz" which cannot be found by enchant library, checked for en_US dictionary, see result of command: echo "zzz" | enchant -l
> > Can we replace the problematic sound of snoring with a different phrase? That change will allow to test unified text checking by EFL and GTK+ WebKit ports.
> 
> I'm not 100% sure about how they used this 'zzz' string but I guess it could be to test the following situation:
> 
>   "a test case containing a valid word which contains a bad word as a substring"
> 
> ...assuming that 'zz' is expected to be invalid while 'zzz' should be valid.

The word "zzz" is tested in two ways:
1) single "zzz" word is verified - it's expected to valid
2) sentence "I would like to sleep, zzz" is verified - it's expected to be valid too.

> 
> > I will upload patch as soon as I get your opinions.
> 
> I think it doesn't hurts to change this as long as the same kind of situations keep being tested

Thanks, for your opinion

[Grzegorz Czajkowski]

Created attachment 179045 [details]
replace problemtaic "zzz" with "buzz"

[Hajime Morrita]

Comment on attachment 179045 [details]
replace problemtaic "zzz" with "buzz"

fair enough.

[WebKit Review Bot]

Comment on attachment 179045 [details]
replace problemtaic "zzz" with "buzz"

Clearing flags on attachment: 179045

Committed r137571: <http://trac.webkit.org/changeset/137571>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.