Bug 104728

Summary: [soup] Unused parameter in ResourceHandleSoup.cpp
Product: WebKit Reporter: KyungTae Kim <ktf.kim>
Component: New BugsAssignee: KyungTae Kim <ktf.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

KyungTae Kim
Reported 2012-12-11 15:16:19 PST
The soupLogPrinter has unused parameter 'logger', comment out it to fix 'unused parameter' build warning. Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:82:20: warning: unused parameter ‘logger’ [-Wunused-parameter]
Attachments
Patch (1.48 KB, patch)
2012-12-11 15:19 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2012-12-11 15:42 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.59 KB, patch)
2012-12-11 16:17 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
KyungTae Kim
Comment 1 2012-12-11 15:19:01 PST
Created attachment 178890 [details] Patch
Martin Robinson
Comment 2 2012-12-11 15:30:46 PST
Comment on attachment 178890 [details] Patch It's a bit odd that some of the arguments are removed entirely and one is commented out. Why the inconsistency?
KyungTae Kim
Comment 3 2012-12-11 15:42:29 PST
Created attachment 178897 [details] Patch
Kentaro Hara
Comment 4 2012-12-11 15:42:55 PST
Comment on attachment 178897 [details] Patch ok
KyungTae Kim
Comment 5 2012-12-11 16:17:34 PST
Created attachment 178911 [details] Patch
WebKit Review Bot
Comment 6 2012-12-11 18:06:29 PST
Comment on attachment 178911 [details] Patch Clearing flags on attachment: 178911 Committed r137400: <http://trac.webkit.org/changeset/137400>
WebKit Review Bot
Comment 7 2012-12-11 18:06:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.