Bug 104694

Summary: Web Inspector: follow up to r136974: handle visibility shortcut in keydown event of ElementsTreeOutline.element
Product: WebKit Reporter: egraether
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

egraether
Reported 2012-12-11 11:51:59 PST
Web Inspector: follow up to r136974: handle visibility shortcut in keydown event of ElementsTreeOutline.element
Attachments
Patch (4.60 KB, patch)
2012-12-11 11:53 PST, egraether 		no flags
DetailsFormatted DiffDiff
Patch (4.84 KB, patch)
2012-12-12 10:32 PST, egraether 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
egraether
Comment 1 2012-12-11 11:53:53 PST
Created attachment 178843 [details] Patch
Pavel Feldman
Comment 2 2012-12-12 09:28:19 PST
Comment on attachment 178843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178843&action=review > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:474 > + _onkeydown: function(event) @param {Event} event > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:478 > + if (!node || !treeElement) No need to check for node here. > Source/WebCore/inspector/front-end/KeyboardShortcut.js:140 > + * @param {KeyboardEvent} event @return {boolean}
egraether
Comment 3 2012-12-12 10:32:34 PST
Created attachment 179078 [details] Patch
WebKit Review Bot
Comment 4 2012-12-12 13:34:54 PST
Comment on attachment 179078 [details] Patch Clearing flags on attachment: 179078 Committed r137510: <http://trac.webkit.org/changeset/137510>
WebKit Review Bot
Comment 5 2012-12-12 13:34:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.