Bug 104687 – check-webkit-style complaining about TestExpectations lines a patch didn't modify

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Dirk Pranke]

See bug 104462 for context ... check-webkit-style seems to be complaining about errors in TestExpectation lines unrelated to the patch. This is causing the style bot to fail and will block patches in the commit queue. 

I also saw the error locally when I landed the patch by hand.

[Dirk Pranke]

Created attachment 178853 [details]
Patch

[Ojan Vafai]

Comment on attachment 178853 [details]
Patch

In theory we could fix this properly by having both lines involved in a duplicate expectation get a lint error? Then we wouldn't lose any coverage here.

We'd still want line filtering on for that though, right? So this patch is correct either way, but a FIXME would be nice. It's going to be a pain to keep the lint-webkitpy step green.

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 178853 [details])
> In theory we could fix this properly by having both lines involved in a duplicate expectation get a lint error? Then we wouldn't lose any coverage here.
> 

Perhaps. A complication would be that you wouldn't want to print both lines to stderr in the lint-test-files case, but we can probably do something.


> We'd still want line filtering on for that though, right? So this patch is correct either way, but a FIXME would be nice. It's going to be a pain to keep the lint-webkitpy step green.

I think I'll file a bug for the enhancement instead.

[Dirk Pranke]

filed https://bugs.webkit.org/show_bug.cgi?id=104712 ; ended up adding a FIXME as well :).

[Dirk Pranke]

Committed r137355: <http://trac.webkit.org/changeset/137355>