Bug 104681 – AX: Make isActionSupported cross-platform.

• Component: Accessibility
• Status: RESOLVED FIXED

[Dominic Mazzoni]

The isActionSupported method in DRT/WKTR takes a string parameter, which is platform-specific. With a minor refactoring, we could replace this with a cross-platform method and enable a few tests to run on more platforms.

[Dominic Mazzoni]

Created attachment 178838 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[chris fleizach]

Comment on attachment 178838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178838&action=review

> Source/WebKit/chromium/src/WebAccessibilityObject.cpp:588
> +    UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);

this seems like it should be on AccessibilityObject since all clients will benefit

> Source/WebKit/chromium/src/WebAccessibilityObject.cpp:616
> +    UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);

i believe this call is already in axObject->press()

[EFL EWS Bot]

Comment on attachment 178838 [details]
Patch

Attachment 178838 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15241955

[Dominic Mazzoni]

Created attachment 178846 [details]
Patch

[Dominic Mazzoni]

Comment on attachment 178838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178838&action=review

>> Source/WebKit/chromium/src/WebAccessibilityObject.cpp:588
>> +    UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
> 
> this seems like it should be on AccessibilityObject since all clients will benefit

Sure, done.

>> Source/WebKit/chromium/src/WebAccessibilityObject.cpp:616
>> +    UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
> 
> i believe this call is already in axObject->press()

You're right. Fixed.

[chris fleizach]

Comment on attachment 178846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178846&action=review

looks good. minor comments you can fix in commit

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:678
> +    return [actions containsObject:@"AXPress"];

this should be NSAccessibilityPressAction

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:688
> +    return [actions containsObject:@"AXIncrement"];

NSAccessibilityIncrementAction

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:698
> +    return [actions containsObject:@"AXDecrement"];

NSAccessibilityDecrementAction

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:686
> +    return [actions containsObject:@"AXPress"];

ditto with the name used

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:696
> +    return [actions containsObject:@"AXIncrement"];

ditto with the name used

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:706
> +    return [actions containsObject:@"AXDecrement"];

ditto with the name used

> LayoutTests/platform/mac/accessibility/slider-supports-actions.html:25
> +          var succeeded = obj.isIncrementActionSupported() == true;

seems like we have remove these "== true" as they're redundant

> LayoutTests/platform/mac/accessibility/slider-supports-actions.html:28
> +          var succeeded = obj.isDecrementActionSupported() == true;

seems like we have remove these "== true" as they're redundant

> LayoutTests/platform/mac/accessibility/slider-supports-actions.html:38
> +          var succeeded = obj.isIncrementActionSupported() == true;

seems like we have remove these "== true" as they're redundant

> LayoutTests/platform/mac/accessibility/slider-supports-actions.html:41
> +          var succeeded = obj.isDecrementActionSupported() == true;

seems like we have remove these "== true" as they're redundant

[Dominic Mazzoni]

Created attachment 178952 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 178952 [details]
Patch for landing

Clearing flags on attachment: 178952

Committed r137414: <http://trac.webkit.org/changeset/137414>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.