Summary: | [Drosera] The Console toolbar button should bring the console window to the front | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pete Parks <pete.parks> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | CLOSED FIXED | ||||||||
Severity: | Normal | CC: | mitz, mrowe | ||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Pete Parks
2006-08-17 13:14:07 PDT
I think there should also be a menu command that does the same thing the toolbar button does. Created attachment 11270 [details]
attempted patch
Fixes focus bug and makes command + L activate the console as well.
Comment on attachment 11270 [details]
attempted patch
Actually i think this should be: if (consoleWindow.blur)
if (!consoleWindow.focus())
Dosent make sense.
Comment on attachment 11270 [details]
attempted patch
Actually this should just be an else case. No harm in calling focus() if the console is already focused.
if (!consoleWindow)
consoleWindow = window.open("console.html", "console", "top=200, left=200, width=500, height=300, toolbar=yes, resizable=yes");
+ else
+ consoleWindow.focus();
No need for the {} braces on the if and else, since they are one line statments. My if (consoleWindow.blur) comment was wrong also. THere is no property on the window bject to test if it already has focus. The original patch was just always focusing the window (twice!). Created attachment 11280 [details]
revised patch
Closing since Drosera has been replaced by the new Web Inspector debugger. Moving to the New Bugs component so the Drosera component can be closed and removed. |