Bug 104677

Summary: [Qt] Fix the inspector not showing up on Windows
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jturcotte, vestbo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 106554    
Bug Blocks:    
Attachments:
Description Flags
Patch hausmann: review+

Jocelyn Turcotte
Reported 2012-12-11 08:22:07 PST
[Qt] Fix the inspector not showing up on Windows
Attachments
Patch (2.89 KB, patch)
2012-12-11 08:26 PST, Jocelyn Turcotte 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2012-12-11 08:26:39 PST
Created attachment 178811 [details] Patch
Simon Hausmann
Comment 2 2012-12-11 23:58:40 PST
Comment on attachment 178811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178811&action=review r=me with a small change :) > Source/api.pri:24 > + include(WebCore/WebCore.pri) I think if you move this whole block until _after_ the load(webkit_modules) part in api.pri, then you can remove the inclusion of WebCore.pri and therefore avoid it being included twice (webkit_modules will also include it due to WEBKIT += webcore) (WebCore.pri is designed to be included only once, as it does += on LIBS and other variables instead of *=)
Jocelyn Turcotte
Comment 3 2012-12-12 02:11:20 PST
(In reply to comment #2) > I think if you move this whole block until _after_ the load(webkit_modules) part in api.pri, then you can remove the inclusion of WebCore.pri and therefore avoid it being included twice (webkit_modules will also include it due to WEBKIT += webcore) > > (WebCore.pri is designed to be included only once, as it does += on LIBS and other variables instead of *=) It does work if I move it, pretty good point, thanks.
Jocelyn Turcotte
Comment 4 2012-12-12 02:14:13 PST
Committed r137436: <http://trac.webkit.org/changeset/137436>
Note You need to log in before you can comment on or make changes to this bug.