Bug 104595

Summary:	fast/css/empty-generated-content.html needs to be rebaselined after 104462
Product:	WebKit	Reporter:	Elliott Sprehn <esprehn>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	pkasting, rniwa
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	104462
Bug Blocks:

Description Elliott Sprehn 2012-12-10 14:21:45 PST

This test used to have an extra anonymous block for some reason I can't explain. The new generated content implementation seems to fix it.

Comment 1 Ryosuke Niwa 2013-03-20 17:05:29 PDT

Committed r146414: <http://trac.webkit.org/changeset/146414>

Comment 2 Peter Kasting 2013-03-21 00:03:03 PDT

Rebaselined in r146441.

Comment 3 Ryosuke Niwa 2013-03-21 00:08:37 PDT

Don't we need rebaselines on Qt, GTK+, EFL, etc...?

Comment 4 Peter Kasting 2013-03-21 00:13:06 PDT

Bug 104462 only touched the Mac and Chromium TestExpectations files.  The Qt, GTK, and EFL TestExpectations files don't refer to this test, unless I looked at the wrong files.

Did I miss anything?

Comment 5 Ryosuke Niwa 2013-03-21 00:19:02 PDT

(In reply to comment #4)
> Bug 104462 only touched the Mac and Chromium TestExpectations files.  The Qt, GTK, and EFL TestExpectations files don't refer to this test, unless I looked at the wrong files.

I suspect that's because only Mac and Chromium ports' EWS bots run tests.

Comment 6 Elliott Sprehn 2013-03-21 00:20:16 PDT

(In reply to comment #5)
> (In reply to comment #4)
> > Bug 104462 only touched the Mac and Chromium TestExpectations files.  The Qt, GTK, and EFL TestExpectations files don't refer to this test, unless I looked at the wrong files.
> 
> I suspect that's because only Mac and Chromium ports' EWS bots run tests.

Yup. I asked at the time (which was before the global TestExpectations file existed) and was told to only change ones for the EWS.

Comment 7 Ryosuke Niwa 2013-03-21 00:20:42 PDT

But it does seem like they all have .txt/.png results.

Comment 8 Ryosuke Niwa 2013-03-21 00:21:22 PDT

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Bug 104462 only touched the Mac and Chromium TestExpectations files.  The Qt, GTK, and EFL TestExpectations files don't refer to this test, unless I looked at the wrong files.
> > 
> > I suspect that's because only Mac and Chromium ports' EWS bots run tests.
> 
> Yup. I asked at the time (which was before the global TestExpectations file existed) and was told to only change ones for the EWS.

That's just insanely stupid. We're working around the fact EWS would cq- the patch. We need to improve the tool so that we don't have to do such a thing.

Comment 9 Peter Kasting 2013-03-21 00:33:00 PDT

I am fine with this being reopened (hopefully with clarity added as to what someone who wants to fix should do).  It's past midnight here and my brain is getting fuzzy enough that I'm not sure I would write the right thing myself.

Comment 10 Ryosuke Niwa 2013-03-21 00:34:29 PDT

(In reply to comment #9)
> I am fine with this being reopened (hopefully with clarity added as to what someone who wants to fix should do).  It's past midnight here and my brain is getting fuzzy enough that I'm not sure I would write the right thing myself.

Sorry, I think closing the bug is the right thing to do for now. I just had to manually verify that EFL, GTK+, & Qt have respective -expected files, and they indeed do.