Bug 104593

Summary:

Add in-band text track cues only once

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, feature-media-reviews, gyuyoung.kim, ojan.autocc, rakuco, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	buildbot: commit-queue-
Skipped new tests on platforms that don't support it.	none
Fix style errors	none

Eric Carlson

Reported 2012-12-10 13:47:09 PST

A media engine may deliver cues from in-band tracks every time the media data is parsed, but we should only add each cue to WebKit's TextTrack once.

Attachments
Proposed patch (15.80 KB, patch) 2012-12-17 15:29 PST, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Skipped new tests on platforms that don't support it. (deleted) 2012-12-17 16:29 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Fix style errors (19.68 KB, patch) 2012-12-17 16:41 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2012-12-10 13:47:22 PST

<rdar://problem/12849532>

Eric Carlson

Comment 2 2012-12-17 15:29:57 PST

Created attachment 179813 [details] Proposed patch

Build Bot

Comment 3 2012-12-17 16:14:30 PST

Comment on attachment 179813 [details] Proposed patch Attachment 179813 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15363937 New failing tests: media/track/track-in-band-cues-added-once.html

Eric Carlson

Comment 4 2012-12-17 16:29:14 PST

Created attachment 179828 [details] Skipped new tests on platforms that don't support it.

WebKit Review Bot

Comment 5 2012-12-17 16:31:44 PST

Attachment 179828 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1 Source/WebCore/html/track/InbandTextTrack.cpp:139: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/html/track/InbandTextTrack.cpp:163: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 6 2012-12-17 16:41:25 PST

Created attachment 179832 [details] Fix style errors

Dean Jackson

Comment 7 2012-12-17 17:15:09 PST

Comment on attachment 179832 [details] Fix style errors View in context: https://bugs.webkit.org/attachment.cgi?id=179832&action=review > Source/WebCore/html/track/InbandTextTrack.cpp:154 > + if (!cue) > + return false; > + if (cue->startTime() != startTime) > + return false; > + if (cue->endTime() != endTime) > + return false; > + if (cue->text() != content) > + return false; > + if (cue->cueSettings() != settings) > + return false; > + if (cue->id() != id) > + return false; Is there any reason you chose this form over a single if statement? It is easier to read :) > LayoutTests/media/track/track-in-band-cues-added-once.html:4 > + <head> > + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> No title?

WebKit Review Bot

Comment 8 2012-12-18 07:24:35 PST

Comment on attachment 179832 [details] Fix style errors Clearing flags on attachment: 179832 Committed r138017: <http://trac.webkit.org/changeset/138017>

WebKit Review Bot

Comment 9 2012-12-18 07:24:40 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.