Bug 104590

Summary: [GStreamer] Avoid linking to GStreamer video libraries if only using ENABLE_VIDEO
Product: WebKit Reporter: Jesus Sanchez-Palencia <jesus>
Component: WebCore Misc.Assignee: Jesus Sanchez-Palencia <jesus>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, menard, mrobinson, pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jesus Sanchez-Palencia
Reported 2012-12-10 13:20:17 PST
Currently ports using GStreamer can't build with ENABLE_AUDIO only because bool getVideoSizeAndFormatFromCaps from Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.h is using gst_video_* functions and, therefore, must be linked against GStreamer video libs. However, getVideoSizeAndFormatFromCaps is currently only used when ENABLE_VIDEO is set, so it doesn't need to be always built (i.e. when all want to have is ENABLE_AUDIO). Patch is coming.
Attachments
Patch (2.73 KB, patch)
2012-12-10 13:26 PST, Jesus Sanchez-Palencia 		no flags
DetailsFormatted DiffDiff
Patch (3.81 KB, patch)
2012-12-11 05:20 PST, Jesus Sanchez-Palencia 		no flags
DetailsFormatted DiffDiff
Patch (3.32 KB, patch)
2012-12-11 05:38 PST, Jesus Sanchez-Palencia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jesus Sanchez-Palencia
Comment 1 2012-12-10 13:26:03 PST
Created attachment 178621 [details] Patch
Philippe Normand
Comment 2 2012-12-11 00:33:11 PST
Comment on attachment 178621 [details] Patch Hum, how about protecting the whole module with #if USE(GSTREAMER)? Sorry it's my fault it's not been done before.
Philippe Normand
Comment 3 2012-12-11 00:50:07 PST
(In reply to comment #2) > (From update of attachment 178621 [details]) > Hum, how about protecting the whole module with #if USE(GSTREAMER)? Sorry it's my fault it's not been done before. That would be in complement with your patch. So, globally protect with USE(GSTREAMER) and protect that function with ENABLE(VIDEO).
Jesus Sanchez-Palencia
Comment 4 2012-12-11 05:20:50 PST
Created attachment 178780 [details] Patch
Philippe Normand
Comment 5 2012-12-11 05:30:15 PST
Comment on attachment 178780 [details] Patch Ok but I don't think adding Indt's copyright for such a small patch is necessary.
Jesus Sanchez-Palencia
Comment 6 2012-12-11 05:32:52 PST
(In reply to comment #5) > (From update of attachment 178780 [details]) > Ok but I don't think adding Indt's copyright for such a small patch is necessary. You are right, power of habit... I will it before landing.
Jesus Sanchez-Palencia
Comment 7 2012-12-11 05:38:58 PST
Created attachment 178781 [details] Patch
WebKit Review Bot
Comment 8 2012-12-11 06:00:09 PST
Comment on attachment 178781 [details] Patch Clearing flags on attachment: 178781 Committed r137301: <http://trac.webkit.org/changeset/137301>
WebKit Review Bot
Comment 9 2012-12-11 06:00:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.