Bug 104561

Summary:

WebKitWebViewBase produces a warning if compiled with gcc

Product:

WebKit

Reporter:

Alberto Garcia <berto>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

cgarcia, gustavo, mrobinson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mrobinson: review+, webkit.review.bot: commit-queue-
Patch v2	none

Description Alberto Garcia 2012-12-10 08:10:03 PST

The webkit_web_view_base_get_type() prototype uses C++ syntax that
produces a warning when compiled with gcc:

WebKitWebViewBase.h:68:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]

Comment 1 Alberto Garcia 2012-12-10 08:18:46 PST

Created attachment 178558 [details]
Patch

Comment 2 WebKit Review Bot 2012-12-10 08:49:35 PST

Comment on attachment 178558 [details]
Patch

Rejecting attachment 178558 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15227688

Comment 3 Alberto Garcia 2012-12-10 08:56:01 PST

Created attachment 178563 [details]
Patch v2

Oops, I removed the "Reviewed by" line from the ChangeLog by mistake.

Here's the new patch.

Comment 4 WebKit Review Bot 2012-12-10 08:59:10 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 5 WebKit Review Bot 2012-12-10 09:15:12 PST

Comment on attachment 178563 [details]
Patch v2

Clearing flags on attachment: 178563

Committed r137164: <http://trac.webkit.org/changeset/137164>

Comment 6 WebKit Review Bot 2012-12-10 09:15:15 PST

All reviewed patches have been landed.  Closing bug.