Bug 104529 – [Qt] Builds for Mac are tied to the OS system instead of the SDK version.

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Michael Brüning]

SSIA, it's not possible to build for another SDK as the WebKitSystemInterface library version is chosen based on the OS version, not on the SDK that the build is made with.

[Michael Brüning]

Created attachment 178500 [details]
Patch

[Zeno Albisser]

Comment on attachment 178500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178500&action=review

> Source/WebCore/WebCore.pri:183
> +        equals(DARWIN_MAJOR_VERSION, "9") | contains(QMAKE_MAC_SDK, ".*MacOSX10.5.sdk.*") {

Isn't this going to cause trouble, when somebody tries to build for target MacOSX10.8, on a machine running MacOSX10.7 ? (Building for a newer version than running on the build-system).
Now obviously we currently do not support a different target than the one building on. So this would probably still be an improvement. But I am not sure if it is the correct solution.

[Michael Brüning]

(In reply to comment #2)
> Isn't this going to cause trouble, when somebody tries to build for target MacOSX10.8, on a machine running MacOSX10.7 ? (Building for a newer version than running on the build-system).

True, that would not work afaics. The question is whether we want the complete solution now or improve gradually...

[Michael Brüning]

Created attachment 178509 [details]
Patch

[Zeno Albisser]

(In reply to comment #4)
LGTM :)

[Simon Hausmann]

Comment on attachment 178509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178509&action=review

> Source/WebCore/WebCore.pri:188
> +            SYSTEM_LIBRARY_PATH = $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceLeopard.a
> +        } else:contains(QMAKE_MAC_SDK, ".*MacOSX10.6.sdk.*") {
> +            SYSTEM_LIBRARY_PATH = $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a
> +        } else:contains(QMAKE_MAC_SDK, ".*MacOSX10.7.sdk.*") {

I think references to Leopard and SnowLeopard can be removed before landing. These libraries do not exist anymore (see WebKitLibraries/). Only Lion and MountainLion are supported in trunk.

[Michael Brüning]

Committed r137139: <http://trac.webkit.org/changeset/137139>

[Thiago Macieira]

The commit is missing an explanation of why the two libraries for Lion and Mountain Lion are no longer being added.

With no explanation, it sounds like an oversight / mistake. Can someone bring them back?

[Michael Brüning]

(In reply to comment #8)
> The commit is missing an explanation of why the two libraries for Lion and Mountain Lion are no longer being added.
> 
> With no explanation, it sounds like an oversight / mistake. Can someone bring them back?

The libraries were removed since Apple no longer supports the WebKitSystemInterfaces for these on trunk and the libraries that were checked in here had not been updated in a while and were most likely not usable anymore. I do not see a big chance to bring them back to be honest.