| Summary: | [EFL] [WebGL] Path is not resized correctly | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kalyan <kalyan.kondapally> | ||||||
| Component: | WebKit EFL | Assignee: | Kalyan <kalyan.kondapally> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, kenneth, lucas.de.marchi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 103105, 104459 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kalyan
2012-12-08 15:37:51 PST
(In reply to comment #0) > In GraphicsContext3D::paintToCanvas , we flip the contents and draw on the surface. The operations needed to flip the image(translation and scale ) are done before the rectangle with correct size is added to current path. This results in drawing pixels at wrong position. > > We could also combine the translation and scale operations into one by using matrix. Problem can be seen with LayoutTests/fast/canvas/webgl/canvas-test.html Created attachment 178383 [details]
patch
Comment on attachment 178383 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=178383&action=review > Source/WebCore/ChangeLog:9 > + The operations done to flip the image (translation and scale ) are done before rectangle with correct size remove space before ) > Source/WebCore/ChangeLog:10 > + is added to current path. This results in updating pixels at wrong positions. . Remove the trailing " ." Created attachment 178436 [details]
patchv2
review changes
Comment on attachment 178436 [details] patchv2 Clearing flags on attachment: 178436 Committed r137098: <http://trac.webkit.org/changeset/137098> All reviewed patches have been landed. Closing bug. |