Bug 104422 – IndexedDB: Propagate more leveldb errors to script

• Component: New Bugs
• Status: RESOLVED FIXED

[David Grogan]

IndexedDB: Propagate all leveldb errors to script

[David Grogan]

Created attachment 178314 [details]
Patch

[David Grogan]

Created attachment 178316 [details]
Patch

[David Grogan]

Created attachment 178318 [details]
Patch

[David Grogan]

Created attachment 178319 [details]
Patch

[WebKit Review Bot]

Attachment 178319 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Grogan]

Created attachment 178321 [details]
Patch

[David Grogan]

Josh or Alec, could you take a look?

Everything remaining is a consistency error, rather than a leveldb IO error.

[Joshua Bell]

Comment on attachment 178321 [details]
Patch

Overall LGTM (s/good/awesome/)

View in context: https://bugs.webkit.org/attachment.cgi?id=178321&action=review

> Source/WebCore/ChangeLog:11
> +        Nothing called getBool, so it is deleted.

Yeah, I had a FIXME to add it but I don't think anything was converted over to use it. :P

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:378
> +                InternalError(IDBLevelDBBackingStoreReadErrorSetupMetadata);

Other places in open() eschew InternalError and increment a specific histogram (since we'd hope to catch most errors here). Do the same thing here, or stick with InternalError?

> Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:471
> +        transaction->abort(error);

Use error.release()

[David Grogan]

Comment on attachment 178321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178321&action=review

>> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:378
>> +                InternalError(IDBLevelDBBackingStoreReadErrorSetupMetadata);
> 
> Other places in open() eschew InternalError and increment a specific histogram (since we'd hope to catch most errors here). Do the same thing here, or stick with InternalError?

Changed.

>> Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:471
>> +        transaction->abort(error);
> 
> Use error.release()

Done.

[David Grogan]

Created attachment 178638 [details]
Patch

[David Grogan]

Tony, could you review this?

[WebKit Review Bot]

Comment on attachment 178638 [details]
Patch

Clearing flags on attachment: 178638

Committed r137223: <http://trac.webkit.org/changeset/137223>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.