Bug 104409

Summary:

Clear failed image loads when an <img> is adopted into a different document

Product:

WebKit

Reporter:

Adam Klein <adamk>

Component:

New Bugs

Assignee:

Adam Klein <adamk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, beidson, darin, japhet, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Adam Klein

Reported 2012-12-07 16:00:58 PST

Remove bogus assert from ImageLoader

Attachments
Patch (3.27 KB, patch) 2012-12-07 16:06 PST, Adam Klein	no flags	Details Formatted Diff Diff
Patch (4.63 KB, patch) 2012-12-14 12:25 PST, Adam Klein	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Klein

Comment 1 2012-12-07 16:06:46 PST

Created attachment 178298 [details] Patch

Adam Klein

Comment 2 2012-12-07 16:07:45 PST

From reading the ways m_failedLoadURL is used, it seems like it's safe to just remove this assert, but I'm not at all an ImageLoader expert so I'm looking for help from the reviewer to decide if I need to do something other than remove the assert.

Darin Adler

Comment 3 2012-12-08 11:05:56 PST

Comment on attachment 178298 [details] Patch I think that the gist of this assertion is to say that the function doesn’t do what anything appropriate with the failed load URL, which the original programmer thought was OK because that can never happen. Removing the assertion is clearly OK, but I think that additional work, such as clearing m_failedLoadURL, may be needed.

Adam Klein

Comment 4 2012-12-10 10:21:50 PST

Clearing m_failedLoadURL seems reasonable in this case, and at worst will just cause a re-fetch, it looks like. Shall I just do that?

Adam Klein

Comment 5 2012-12-14 12:25:23 PST

Created attachment 179514 [details] Patch

Adam Klein

Comment 6 2012-12-18 11:30:22 PST

Darin, can you take another look at this?

WebKit Review Bot

Comment 7 2013-01-03 11:53:45 PST

Comment on attachment 179514 [details] Patch Clearing flags on attachment: 179514 Committed r138724: <http://trac.webkit.org/changeset/138724>