Bug 104405

Summary: webkit-patch print-expectations doesn't work right for platforms w/ shared expectations
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric: review+

Dirk Pranke
Reported 2012-12-07 14:56:19 PST
webkit-patch print-expectations doesn't work right for platforms w/ shared expectations
Attachments
Patch (5.04 KB, patch)
2012-12-07 14:57 PST, Dirk Pranke 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-12-07 14:57:57 PST
Created attachment 178287 [details] Patch
Eric Seidel (no email)
Comment 2 2012-12-07 15:19:15 PST
Comment on attachment 178287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178287&action=review Rs=me > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:70 > + # FIXME: This won't work if multiple ports share a TestExpectations file but support different modifiers in the file. Should we be asserting?
Dirk Pranke
Comment 3 2012-12-07 15:57:09 PST
(In reply to comment #2) > (From update of attachment 178287 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178287&action=review > > Rs=me > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:70 > > + # FIXME: This won't work if multiple ports share a TestExpectations file but support different modifiers in the file. > > Should we be asserting? No, because there's no good way to detect that at the moment.
Dirk Pranke
Comment 4 2012-12-10 11:06:00 PST
Committed r137184: <http://trac.webkit.org/changeset/137184>
Note You need to log in before you can comment on or make changes to this bug.