Bug 104402

Summary:

Missing ENABLE(SVG) in ElementRareData breaks --no-svg build

Product:

WebKit

Reporter:

Helder Correia <helder.correia>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ojan.autocc, webkit.review.bot, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+, webkit.review.bot: commit-queue-

Helder Correia

Reported 2012-12-07 14:28:54 PST

Build with --no-svg broken after patch from bug 90405.

Attachments
Patch (1.44 KB, patch) 2012-12-07 14:30 PST, Helder Correia	darin: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Helder Correia

Comment 1 2012-12-07 14:30:03 PST

Created attachment 178277 [details] Patch

WebKit Review Bot

Comment 2 2012-12-08 17:42:50 PST

Comment on attachment 178277 [details] Patch Rejecting attachment 178277 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rin Adler']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/ElementRareData.h Hunk #1 FAILED at 106. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/ElementRareData.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Darin Adler']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15228010

Helder Correia

Comment 3 2012-12-08 18:13:16 PST

Fixed few hours ago by direct commit r137027.

Note You need to log in before you can comment on or make changes to this bug.