Harden RenderBox::canBeScrolledAndHasScrollableArea logic

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Antonio Gomes]

353 // The RenderBox::canbeScrolledAndHasScrollableArea method returns true for the
354 // following scenario, for example:
355 // (1) a div that has a vertical overflow but no horizontal overflow
356 //     with overflow-y: hidden and overflow-x: auto set.
357 // The version below fixes it.
358 // FIXME: Fix RenderBox::canBeScrolledAndHasScrollableArea method instead.
359 bool InRegionScrollerPrivate::canScrollRenderBox(RenderBox* box)

[Terry Anderson]

*** Bug 109633 has been marked as a duplicate of this bug. ***

[Antonio Gomes]

Created attachment 209200 [details]
patch 0.1 - for EWS (no tests or changelog added yet)

[Antonio Gomes]

Created attachment 209213 [details]
patch 1 - for review

[Simon Fraser (smfr)]

Comment on attachment 209213 [details]
patch 1 - for review

View in context: https://bugs.webkit.org/attachment.cgi?id=209213&action=review

> LayoutTests/ChangeLog:9
> +        ayis if it is scrollable in that direction, according to its style.

axis

> Source/WebCore/rendering/RenderBox.h:467
> +    bool hasScrollableOverflowX() const { return scrollsOverflowX() && scrollWidth() != clientWidth(); }
> +    bool hasScrollableOverflowY() const { return scrollsOverflowY() && scrollHeight() != clientHeight(); }

I'm not convinced that scrollWidth() != clientWidth() is right here.  RenderLayer::hasHorizontalOverflow() does:  scrollWidth() > renderBox()->pixelSnappedClientWidth();

[Antonio Gomes]

https://trac.webkit.org/changeset/154383