Summary: | Harden RenderBox::canBeScrolledAndHasScrollableArea logic | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||||
Component: | Layout and Rendering | Assignee: | Antonio Gomes <tonikitoo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, commit-queue, esprehn+autocc, esprehn, glenn, jkjiang, kondapallykalyan, simon.fraser, skyostil, tdanderson | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antonio Gomes
2012-12-07 08:30:01 PST
*** Bug 109633 has been marked as a duplicate of this bug. *** Created attachment 209200 [details]
patch 0.1 - for EWS (no tests or changelog added yet)
Created attachment 209213 [details]
patch 1 - for review
Comment on attachment 209213 [details] patch 1 - for review View in context: https://bugs.webkit.org/attachment.cgi?id=209213&action=review > LayoutTests/ChangeLog:9 > + ayis if it is scrollable in that direction, according to its style. axis > Source/WebCore/rendering/RenderBox.h:467 > + bool hasScrollableOverflowX() const { return scrollsOverflowX() && scrollWidth() != clientWidth(); } > + bool hasScrollableOverflowY() const { return scrollsOverflowY() && scrollHeight() != clientHeight(); } I'm not convinced that scrollWidth() != clientWidth() is right here. RenderLayer::hasHorizontalOverflow() does: scrollWidth() > renderBox()->pixelSnappedClientWidth(); |