Summary: | [Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gwang Yoon Hwang <yoon> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dbates, dpranke, hausmann, ossy, vestbo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gwang Yoon Hwang
2012-12-07 00:20:09 PST
Created attachment 178171 [details]
Patch
Comment on attachment 178171 [details] Patch This patch needs to be rebased following <http://trac.webkit.org/changeset/136931>, which renames the library from QtWebKitWidgets to Qt5WebKitWidgets in webkitdirs::builtDylibPathForName(). Comment on attachment 178171 [details]
Patch
Thanks for the fix, I'll land the rebased patch.
(In reply to comment #3) > (From update of attachment 178171 [details]) > Thanks for the fix, I'll land the rebased patch. Thanks. So, should I upload the rebase patch? Committed r136934: <http://trac.webkit.org/changeset/136934> (In reply to comment #4) > Thanks. > So, should I upload the rebase patch? Not necessary, I already landed the rebased fix. ;) Reopening to attach new patch. Created attachment 178175 [details]
Patch
(In reply to comment #6) > (In reply to comment #4) > > Thanks. > > So, should I upload the rebase patch? > > Not necessary, I already landed the rebased fix. ;) Sorry for noise. I was little bit confused. :) |