Bug 104348

Summary: [Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40
Product: WebKit Reporter: Gwang Yoon Hwang <yoon>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, dpranke, hausmann, ossy, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gwang Yoon Hwang
Reported 2012-12-07 00:20:09 PST
After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to Qt5WebKitWidgets. run-launcher and run-webkit-tests were still looking for QtWebKitWidgets
Attachments
Patch (2.38 KB, patch)
2012-12-07 00:25 PST, Gwang Yoon Hwang 		no flags
DetailsFormatted DiffDiff
Patch (1.60 KB, patch)
2012-12-07 00:54 PST, Gwang Yoon Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gwang Yoon Hwang
Comment 1 2012-12-07 00:25:02 PST
Created attachment 178171 [details] Patch
Daniel Bates
Comment 2 2012-12-07 00:44:00 PST
Comment on attachment 178171 [details] Patch This patch needs to be rebased following <http://trac.webkit.org/changeset/136931>, which renames the library from QtWebKitWidgets to Qt5WebKitWidgets in webkitdirs::builtDylibPathForName().
Csaba Osztrogonác
Comment 3 2012-12-07 00:46:51 PST
Comment on attachment 178171 [details] Patch Thanks for the fix, I'll land the rebased patch.
Gwang Yoon Hwang
Comment 4 2012-12-07 00:50:13 PST
(In reply to comment #3) > (From update of attachment 178171 [details]) > Thanks for the fix, I'll land the rebased patch. Thanks. So, should I upload the rebase patch?
Csaba Osztrogonác
Comment 5 2012-12-07 00:51:56 PST
Committed r136934: <http://trac.webkit.org/changeset/136934>
Csaba Osztrogonác
Comment 6 2012-12-07 00:53:07 PST
(In reply to comment #4) > Thanks. > So, should I upload the rebase patch? Not necessary, I already landed the rebased fix. ;)
Gwang Yoon Hwang
Comment 7 2012-12-07 00:54:55 PST
Reopening to attach new patch.
Gwang Yoon Hwang
Comment 8 2012-12-07 00:54:58 PST
Created attachment 178175 [details] Patch
Gwang Yoon Hwang
Comment 9 2012-12-07 00:57:44 PST
(In reply to comment #6) > (In reply to comment #4) > > Thanks. > > So, should I upload the rebase patch? > > Not necessary, I already landed the rebased fix. ;) Sorry for noise. I was little bit confused. :)
Note You need to log in before you can comment on or make changes to this bug.