Bug 104334

Summary: [BlackBerry] make "isVideo" information available to platform media player
Product: WebKit Reporter: Max Feil <mfeil>
Component: WebKit BlackBerryAssignee: Max Feil <mfeil>
Status: CLOSED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Max Feil
Reported 2012-12-06 19:19:07 PST
The platform player needs to know whether the element is <video> or <audio>, so it can make certain decisions before metadata is ready. Basically it will use "isVideo" sometimes instead of "hasVideo". This is part of a performance optimization refactor which does not change functionality so no new tests are required. The bulk of the code changes are covered under PR234726 in the platform repository.
Attachments
Patch (2.29 KB, patch)
2012-12-06 19:34 PST, Max Feil 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Max Feil
Comment 1 2012-12-06 19:34:04 PST
Created attachment 178138 [details] Patch
Rob Buis
Comment 2 2012-12-07 04:54:59 PST
Comment on attachment 178138 [details] Patch LGTM
WebKit Review Bot
Comment 3 2012-12-07 04:58:47 PST
Comment on attachment 178138 [details] Patch Clearing flags on attachment: 178138 Committed r136946: <http://trac.webkit.org/changeset/136946>
WebKit Review Bot
Comment 4 2012-12-07 04:58:52 PST
All reviewed patches have been landed. Closing bug.
Max Feil
Comment 5 2012-12-07 11:56:46 PST
Thanks Rob. Closing.
Note You need to log in before you can comment on or make changes to this bug.