Bug 104287

Summary: [CMake] Consolidate list of files to build for JavaScriptCore
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, mxie, paroga, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch none

Description Laszlo Gombos 2012-12-06 12:29:12 PST 
It seems to me that we can consolidate the list of files to build in the CMake build system and move some some of the files from PlatformXXX.cmake to CMakeLists.txt.
Comment 1 Laszlo Gombos 2012-12-06 12:34:22 PST 
Created attachment 178060 [details]
proposed patch

My preference would be to move jit/ExecutableAllocatorFixedVMPool.cpp to the common list as well as the cpp file itself is guarded already with the appropriate build flags to enable sharing the list of files in the build system. Any feedback on this would be much appreciated.
Comment 2 Laszlo Gombos 2012-12-06 12:34:45 PST 
Comment on attachment 178060 [details]
proposed patch

wrong patch, sorry
Comment 3 Laszlo Gombos 2012-12-06 12:35:33 PST 
Created attachment 178061 [details]
proposed patch
Comment 4 Gyuyoung Kim 2012-12-06 18:02:14 PST 
Comment on attachment 178061 [details]
proposed patch

r=me
Comment 5 WebKit Review Bot 2012-12-06 18:18:10 PST 
Comment on attachment 178061 [details]
proposed patch

Clearing flags on attachment: 178061

Committed r136914: <http://trac.webkit.org/changeset/136914>
Comment 6 WebKit Review Bot 2012-12-06 18:18:14 PST 
All reviewed patches have been landed.  Closing bug.