Bug 104222

Summary:

Profiler should print a helpful message if you pass the wrong arguments

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	oliver: review+

Filip Pizlo

Reported 2012-12-05 22:48:50 PST

Currently it prints something like: [pizlo@wartooth OpenSource] Tools/Scripts/display-profiler-output Tools/Scripts/display-profiler-output:279:in `read': can't convert nil into String (TypeError) from Tools/Scripts/display-profiler-output:279 That's not helpful.

Attachments
the patch (1.28 KB, patch) 2012-12-05 22:49 PST, Filip Pizlo	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2012-12-05 22:49:47 PST

Created attachment 177943 [details] the patch

Filip Pizlo

Comment 2 2012-12-06 13:21:41 PST

Landed in http://trac.webkit.org/changeset/136879

Note You need to log in before you can comment on or make changes to this bug.