Bug 104219 – Page popup should align to the right when the anchor element is rtl

• Component: Forms
• Status: RESOLVED FIXED

[Keishi Hattori]

Page popup should align to the right when the anchor element is rtl

[Keishi Hattori]

Created attachment 177948 [details]
Patch

[Kent Tamura]

Comment on attachment 177948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177948&action=review

> Source/WebCore/Resources/pagepopups/pickerCommon.js:173
> -    resizeWindow(1, 1);
> +    setWindowRect(new Rectangle(window.screen.left, window.screen.top, 1, 1));

I don't understand this.  window.screen is a Screen object, and it has not left and top properties.

[Keishi Hattori]

Created attachment 177954 [details]
Patch

[Keishi Hattori]

(In reply to comment #2)
> (From update of attachment 177948 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177948&action=review
> 
> > Source/WebCore/Resources/pagepopups/pickerCommon.js:173
> > -    resizeWindow(1, 1);
> > +    setWindowRect(new Rectangle(window.screen.left, window.screen.top, 1, 1));
> 
> I don't understand this.  window.screen is a Screen object, and it has not left and top properties.

I made a mistake.

[Kent Tamura]

Comment on attachment 177954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177954&action=review

> Source/WebCore/ChangeLog:15
> +        (setWindowRect): If the window is hidden we want to move first then resize so the popup doesn't flicker.
> +        (isWindowHidden): Returns true if the window is hidden using hideWindow().

nit: These changes look unrelated to the RTL issue.

> Source/WebCore/Resources/pagepopups/pickerCommon.js:172
> +        var isHidden = isWindowHidden();
> +        if (!isHidden)
> +            window.resizeTo(rect.width, rect.height);
>          window.moveTo(rect.x - window.screen.availLeft, rect.y - window.screen.availTop);
> -        window.resizeTo(rect.width, rect.height);
> +        if (isHidden)
> +            window.resizeTo(rect.width, rect.height);

nit: it's ok to write duplicated line to improve readability.

if (isWindowHidden()) {
    window.moveTo(...);
    window.resizeTo(...);
} else {
    window.resizeTo(...);
    window.moveTo(...);
}

[Keishi Hattori]

(In reply to comment #5)
> (From update of attachment 177954 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177954&action=review
> 
> > Source/WebCore/ChangeLog:15
> > +        (setWindowRect): If the window is hidden we want to move first then resize so the popup doesn't flicker.
> > +        (isWindowHidden): Returns true if the window is hidden using hideWindow().
> 
> nit: These changes look unrelated to the RTL issue.

When the element is rtl and we call hideWindow, I see the popup move to the right edge first and then shrink to 1x1.

[Keishi Hattori]

Created attachment 177959 [details]
Patch

[WebKit Review Bot]

Comment on attachment 177959 [details]
Patch

Rejecting attachment 177959 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15158631

[Keishi Hattori]

Created attachment 177962 [details]
Patch

[WebKit Review Bot]

Comment on attachment 177962 [details]
Patch

Clearing flags on attachment: 177962

Committed r136821: <http://trac.webkit.org/changeset/136821>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.