Bug 104213

Summary: [V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2012-12-05 22:09:07 PST
All call sites of v8StringOrNull() and v8StringOrUndefined() have an Isolate.
Attachments
Patch (3.17 KB, patch)
2012-12-05 22:10 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (2.29 KB, patch)
2012-12-06 00:07 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-12-05 22:10:48 PST
Created attachment 177933 [details] Patch
Kentaro Hara
Comment 2 2012-12-06 00:07:48 PST
Created attachment 177957 [details] Patch
Adam Barth
Comment 3 2012-12-06 00:28:55 PST
Comment on attachment 177957 [details] Patch That's great!
WebKit Review Bot
Comment 4 2012-12-06 01:02:53 PST
Comment on attachment 177957 [details] Patch Clearing flags on attachment: 177957 Committed r136820: <http://trac.webkit.org/changeset/136820>
WebKit Review Bot
Comment 5 2012-12-06 01:02:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.