Bug 104199

Summary: IndexedDB: Add webkitErrorMessage to IDBTransaction
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, jsbell, ojan, tony, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

David Grogan
Reported 2012-12-05 18:06:30 PST
IndexedDB: Add webkitErrorMessage to IDBTransaction
Attachments
Patch (11.77 KB, patch)
2012-12-05 18:40 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-12-05 18:40:36 PST
Created attachment 177904 [details] Patch
David Grogan
Comment 2 2012-12-05 18:41:19 PST
Josh or Alec, could one of you take a look?
Joshua Bell
Comment 3 2012-12-06 13:59:10 PST
Comment on attachment 177904 [details] Patch lgtm
David Grogan
Comment 4 2012-12-06 14:02:41 PST
Tony, could you review this?
Tony Chang
Comment 5 2012-12-06 14:10:15 PST
Comment on attachment 177904 [details] Patch Is this property going to be added to the spec?
Joshua Bell
Comment 6 2012-12-06 14:13:59 PST
(In reply to comment #5) > (From update of attachment 177904 [details]) > Is this property going to be added to the spec? I *think* the correct way to do this is to expose a |message| property on DOMError, as is done for DOMException. In DOM3 both types had a |message| property. http://www.w3.org/TR/DOM-Level-3-Core/core.html#ERROR-Interfaces-DOMError In DOM4 neither do, but message is assumed in various specs (and in WebIDL "Exceptions have an associated message, a DOMString, which is exposed on an exception object in a language binding-specific manner") http://www.w3.org/TR/domcore/#domerror http://dev.w3.org/2006/webapi/WebIDL/#idl-exceptions
David Grogan
Comment 7 2012-12-06 14:25:12 PST
(In reply to comment #5) > (From update of attachment 177904 [details]) > Is this property going to be added to the spec? Josh is trying to get a conversation going on #whatwg about this.
WebKit Review Bot
Comment 8 2012-12-06 14:34:53 PST
Comment on attachment 177904 [details] Patch Clearing flags on attachment: 177904 Committed r136894: <http://trac.webkit.org/changeset/136894>
WebKit Review Bot
Comment 9 2012-12-06 14:34:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.