Bug 104193

Summary: Remove harmful string->function cache
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Description Oliver Hunt 2012-12-05 17:31:55 PST 
Remove harmful string->function cache
Comment 1 Oliver Hunt 2012-12-05 17:32:54 PST 
Created attachment 177884 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-12-06 10:47:12 PST 
Comment on attachment 177884 [details]
Patch

Yay to any patch with more red than green ;-)
Comment 3 Oliver Hunt 2012-12-06 11:27:10 PST 
Committed r136860: <http://trac.webkit.org/changeset/136860>
Comment 4 Darin Adler 2012-12-06 11:50:05 PST 
Comment on attachment 177884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177884&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        Remove the string->function code cache that turned out to actually
> +        be quite harmful.

Harmful to what? Performance? Correctness?
Comment 5 Oliver Hunt 2012-12-06 14:17:05 PST 
(In reply to comment #4)
> (From update of attachment 177884 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177884&action=review
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        Remove the string->function code cache that turned out to actually
> > +        be quite harmful.
> 
> Harmful to what? Performance? Correctness?

Performance, it was an in browser memory and cpu usage regression in jsbench and membuster.