Bug 104129
| Summary: | [Qt] Unskip compositing tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Noam Rosenthal <noam> |
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | allan.jensen, jturcotte, kbalazs, ossy, rafael.lobo |
| Priority: | P2 | Keywords: | Qt |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Noam Rosenthal
While Qt supports compositing, the compositing layout tests are skipped. This may cause instability and regressions. We should unskip and maintain the compositing layout tests for Qt.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
Qt-WK1: Found 352 tests; running 0, skipping 352.
Qt-WK2: Found 352 tests; running 272, skipping 80.
I checked the history and https://trac.webkit.org/changeset/109167
skipped compositing tests on Qt-WK1.
And I ran a quick test what if we remove the compositing tests
from qt-5.0-wk1/TestExpectations list:
Found 352 tests; running 335, skipping 17.
Regressions: Unexpected text-only failures (52)
Regressions: Unexpected image-only failures (3)
Regressions: Unexpected crashes (1)
Regressions: Unexpected missing results (24)
It seems we can unskip many of them, but there are many many failures.
Csaba Osztrogonác
I removed compositing from qt-5.0-wk1/TestExpectations, and skip only failing tests - https://trac.webkit.org/changeset/137454
Qt5-WK1: Found 360 tests; running 262, skipping 98.
Qt5-WK2: Found 360 tests; running 280, skipping 80.
Allan Sandfeld Jensen
Mostly solved, and out of scope for WebKit anyway with Qt moved.