Summary: | [Qt] Implement SimpleFontData::platformBoundsForGlyph | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Allan Sandfeld Jensen <allan.jensen> | ||||||
Component: | Text | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | noam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 110211 | ||||||||
Attachments: |
|
Description
Allan Sandfeld Jensen
2012-12-05 08:34:41 PST
Created attachment 177760 [details]
Patch
Comment on attachment 177760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177760&action=review > Source/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp:72 > + // Round to pixel bounds. > + return enclosingIntRect(bounds); Other platforms don't seem to round it, why do we need to? (In reply to comment #2) > (From update of attachment 177760 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177760&action=review > > > Source/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp:72 > > + // Round to pixel bounds. > > + return enclosingIntRect(bounds); > > Other platforms don't seem to round it, why do we need to? Actually I followed Chromium here. They round whenever they don't have subpixel text rendering, and I think we currently use integer metrics only in Qt. I didn't see any artifacts when I ran it without rounding though, so I can't really say we need it. Created attachment 179702 [details]
Patch
Do not round so that returned width matches that of platformWidthForGlyph
Committed r138703: <http://trac.webkit.org/changeset/138703> |