Bug 104123

Summary: [BlackBerry] GeolocationClientBB only holding the latest geolocation permission request
Product: WebKit Reporter: otcheung
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

otcheung
Reported 2012-12-05 07:51:31 PST
We need to support handling multiple geolocation objects coming from different frames in the same page.
Attachments
Patch (7.45 KB, patch)
2012-12-05 08:05 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (7.51 KB, patch)
2012-12-05 08:16 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (7.51 KB, patch)
2012-12-05 08:21 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2012-12-05 08:05:34 PST
Created attachment 177751 [details] Patch
Yong Li
Comment 2 2012-12-05 08:09:59 PST
Comment on attachment 177751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177751&action=review > Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:110 > + ASSERT(it != m_geolocationRequestMap.end()); I still prefer a release build crash...
otcheung
Comment 3 2012-12-05 08:16:08 PST
Created attachment 177754 [details] Patch
Yong Li
Comment 4 2012-12-05 08:19:16 PST
Comment on attachment 177754 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177754&action=review > Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:112 > + if (it != m_geolocationRequestMap.end()) should be it ==
otcheung
Comment 5 2012-12-05 08:21:18 PST
Created attachment 177755 [details] Patch
Yong Li
Comment 6 2012-12-05 08:22:50 PST
Comment on attachment 177755 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177755&action=review > Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:113 > + ASSERT(it != m_geolocationRequestMap.end()); > + if (it == m_geolocationRequestMap.end()) > + return; I feel much better. Thanks!
WebKit Review Bot
Comment 7 2012-12-05 08:49:16 PST
Comment on attachment 177755 [details] Patch Clearing flags on attachment: 177755 Committed r136694: <http://trac.webkit.org/changeset/136694>
WebKit Review Bot
Comment 8 2012-12-05 08:49:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.