Bug 104119

Summary: Web Inspector: [WebGL] prevent GC from collecting WebGLObject instances currently bound to the context state
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 106644    
Attachments:
Description Flags
Patch
none
Added framebuffer attachment object bound resource none

Andrey Adaikin
Reported 2012-12-05 07:15:35 PST
This is to prevent GC from collecting resources bound to a context (WebGL or 2D). Otherwise, for example in WebGL, subsequent calls to gl.getParameter() may return a recently created instance that is no longer bound to a Resource object (thus, no history to replay it later). Patch to follow.
Attachments
Patch (6.88 KB, patch)
2012-12-05 07:22 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Added framebuffer attachment object bound resource (8.09 KB, patch)
2012-12-10 07:52 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2012-12-05 07:22:11 PST
Created attachment 177743 [details] Patch
Andrey Adaikin
Comment 2 2012-12-05 07:26:36 PST
W/o this patch the WebGL capturing/replay would not necessarily work on the following example: http://games.greggman.com/downloads/examples/webgl/webgl-2d-image-3x3-convolution.html
Andrey Adaikin
Comment 3 2012-12-10 07:52:01 PST
Created attachment 178551 [details] Added framebuffer attachment object bound resource
WebKit Review Bot
Comment 4 2012-12-11 00:59:02 PST
Comment on attachment 178551 [details] Added framebuffer attachment object bound resource Clearing flags on attachment: 178551 Committed r137262: <http://trac.webkit.org/changeset/137262>
WebKit Review Bot
Comment 5 2012-12-11 00:59:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.