Bug 104098

Summary: [chromium] Add some null-checks for the touch-lists in TouchEvent
Product: WebKit Reporter: Sadrul Habib Chowdhury <sadrul>
Component: New BugsAssignee: Sadrul Habib Chowdhury <sadrul>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sadrul Habib Chowdhury
Reported 2012-12-05 01:15:18 PST
[chromium] Add some null-checks for the touch-lists in TouchEvent
Attachments
Patch (1.89 KB, patch)
2012-12-05 01:45 PST, Sadrul Habib Chowdhury 		no flags
DetailsFormatted DiffDiff
Patch (3.01 KB, patch)
2012-12-06 11:59 PST, Sadrul Habib Chowdhury 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sadrul Habib Chowdhury
Comment 1 2012-12-05 01:45:29 PST
Created attachment 177697 [details] Patch
Sadrul Habib Chowdhury
Comment 2 2012-12-05 01:59:57 PST
Hi! This is for fixing: https://code.google.com/p/chromium/issues/detail?id=164228
Adam Barth
Comment 3 2012-12-05 17:42:39 PST
Comment on attachment 177697 [details] Patch Can we test these cases? It seems like we should be able to create a Chromium API unit test.
Sadrul Habib Chowdhury
Comment 4 2012-12-06 11:59:14 PST
Created attachment 178050 [details] Patch
Sadrul Habib Chowdhury
Comment 5 2012-12-06 12:01:46 PST
(In reply to comment #3) > (From update of attachment 177697 [details]) > Can we test these cases? It seems like we should be able to create a Chromium API unit test. There are layout-tests that verify that correct mouse-events are generated for touch-events. So just added a super simple unit-test here to verify that empty touch-lists don't cause crashes.
Adam Barth
Comment 6 2012-12-06 12:57:03 PST
Comment on attachment 178050 [details] Patch Thanks.
WebKit Review Bot
Comment 7 2012-12-06 13:14:19 PST
Comment on attachment 178050 [details] Patch Clearing flags on attachment: 178050 Committed r136876: <http://trac.webkit.org/changeset/136876>
WebKit Review Bot
Comment 8 2012-12-06 13:14:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.