Summary: | HTMLCollections namedItem() methods should return null than undefined for empty collections. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aleksei Yu. Semenov <a.semenov> | ||||
Component: | DOM | Assignee: | Vineet Chaudhary (vineetc) <code.vineet> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ap, code.vineet, dglazkov, haraken, japhet, webcomponents-bugzilla, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection | ||||||
Attachments: |
|
Description
Aleksei Yu. Semenov
2012-12-05 00:50:07 PST
Created attachment 188187 [details]
proposed_patch
Comment on attachment 188187 [details]
proposed_patch
The change looks good.
Could you make the test a bit more comprehensive?
It's worth covering some neighboring cases in same test.
Comment on attachment 188187 [details]
proposed_patch
The change looks good. What is the behavior of other browsers?
(In reply to comment #2) > (From update of attachment 188187 [details]) > The change looks good. > Could you make the test a bit more comprehensive? > It's worth covering some neighboring cases in same test. Actually most of the namedItem() tests are already covered in like : fast/dom/collection-item.html collection-nameditem-move-between-documents.html > The change looks good. What is the behavior of other browsers? All other browsers behaves as expected ie. returns null. Comment on attachment 188187 [details]
proposed_patch
Thanks!
Comment on attachment 188187 [details]
proposed_patch
Thank you!!
Comment on attachment 188187 [details] proposed_patch Clearing flags on attachment: 188187 Committed r142831: <http://trac.webkit.org/changeset/142831> All reviewed patches have been landed. Closing bug. (In reply to comment #7) > (From update of attachment 188187 [details]) > Clearing flags on attachment: 188187 > > Committed r142831: <http://trac.webkit.org/changeset/142831> Sorry this seems caused regression bug 109780. |