Bug 104090

Summary: Layout Test fast/css-grid-layout/grid-columns-rows-get-set-multiple.html, grid-columns-rows-get-set.html is failing
Product: WebKit Reporter: Takashi Sakamoto <tasak>
Component: Tools / TestsAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing none

Takashi Sakamoto
Reported 2012-12-04 22:59:29 PST
The following layout test is failing on Mac(Debug), fast/css-grid-layout/grid-columns-rows-get-set-multiple.html fast/css-grid-layout/grid-columns-rows-get-set.html Probable cause: crash log for DumpRenderTree (pid 1178): STDOUT: <empty> STDERR: ASSERTION FAILED: m_type == LengthTrackSizing STDERR: ../rendering/style/GridTrackSize.h(54) : const WebCore::Length &WebCore::GridTrackSize::length() const STDERR: 1 0x45ce48be WebCore::GridTrackSize::length() const STDERR: 2 0x45ce3e49 WebCore::RenderGrid::computePreferredLogicalWidths() STDERR: 3 0x45c3dc52 WebCore::RenderBox::minPreferredLogicalWidth() const STDERR: 4 0x45bbe156 WebCore::RenderBlock::computeBlockPreferredLogicalWidths() STDERR: 5 0x45bbc471 WebCore::RenderBlock::computePreferredLogicalWidths() STDERR: 6 0x45c3dc52 WebCore::RenderBox::minPreferredLogicalWidth() const STDERR: 7 0x45bbe156 WebCore::RenderBlock::computeBlockPreferredLogicalWidths() STDERR: 8 0x45bbc471 WebCore::RenderBlock::computePreferredLogicalWidths() STDERR: 9 0x45c3dc52 WebCore::RenderBox::minPreferredLogicalWidth() const STDERR: 10 0x45bbe156 WebCore::RenderBlock::computeBlockPreferredLogicalWidths() STDERR: 11 0x45bbc471 WebCore::RenderBlock::computePreferredLogicalWidths() STDERR: 12 0x45e7cd5b WebCore::RenderView::computePreferredLogicalWidths() STDERR: 13 0x45c3dc52 WebCore::RenderBox::minPreferredLogicalWidth() const STDERR: 14 0x435a3876 WebKit::WebFrameImpl::contentsPreferredWidth() const STDERR: 15 0x42e4a050 WebViewHost::didUpdateLayout() STDERR: 16 0x4367e90e WebKit::WebViewImpl::layoutUpdated(WebKit::WebFrameImpl*) STDERR: 17 0x434af33a WebKit::ChromeClientImpl::layoutUpdated(WebCore::Frame*) const STDERR: 18 0x45985a7a WebCore::FrameView::layout(bool) STDERR: 19 0x4597fd92 WebCore::FrameView::layoutTimerFired(WebCore::Timer<WebCore::FrameView>*) STDERR: 20 0x459a7e97 WebCore::Timer<WebCore::FrameView>::fired() STDERR: 21 0x449fb32b WebCore::ThreadTimers::sharedTimerFiredInternal() STDERR: 22 0x449fb0af WebCore::ThreadTimers::sharedTimerFired()
Attachments
Patch for landing (1.68 KB, patch)
2013-01-08 17:19 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Sakamoto
Comment 1 2012-12-04 23:10:33 PST
Committed r136644: <http://trac.webkit.org/changeset/136644>
Julien Chaffraix
Comment 2 2013-01-08 15:43:18 PST
r139025 / bug 104700 removed the bad call to GridTrackSize::length in RenderGrid::computePreferredLogicalWidths() and the tests don't ASSERT anymore per http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss-grid-layout%2Fgrid-columns-rows-get-set-multiple.html I am going to re-enable them.
Julien Chaffraix
Comment 3 2013-01-08 17:19:48 PST
Created attachment 181810 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-01-08 19:22:49 PST
Comment on attachment 181810 [details] Patch for landing Clearing flags on attachment: 181810 Committed r139147: <http://trac.webkit.org/changeset/139147>
WebKit Review Bot
Comment 5 2013-01-08 19:22:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.