Bug 104086 – [BlackBerry] new target window would cause the url being loaded twice

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Mary Wu]

When webkit need to open window for a new target like (<a href="abc.html" target="_blank">new target</a>), it would load the url subsequently after createWindow. But the browser side would load the url again when it get the OpenWindowEvent from native, which causes the url be loaded twice. We should make sure that createWindow() be used to create a new window only, not loading url.

[Mary Wu]

Created attachment 177667 [details]
Patch

[Yong Li]

+Jacky

Jacky fixed a similar issue recently. Jacky, can you take a look at this patch?

[Jacky Jiang]

(In reply to comment #2)
> +Jacky
> 
> Jacky fixed a similar issue recently. Jacky, can you take a look at this patch?

Yes, it's the similar issue of mine, just different situation.   R+ from me Yong.

[Yong Li]

Comment on attachment 177667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177667&action=review

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:962
>  Frame* FrameLoaderClientBlackBerry::dispatchCreatePage(const NavigationAction& navigation)

Jacky mentioned this patch could give a warning as navigation will become unused.

[Mary Wu]

(In reply to comment #4)
> (From update of attachment 177667 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177667&action=review
> 
> > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:962
> >  Frame* FrameLoaderClientBlackBerry::dispatchCreatePage(const NavigationAction& navigation)
> 
> Jacky mentioned this patch could give a warning as navigation will become unused.

oh, thanks, will fix the warning.

[Mary Wu]

Created attachment 178163 [details]
Patch

[WebKit Review Bot]

Comment on attachment 178163 [details]
Patch

Rejecting attachment 178163 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15174582

[Mary Wu]

Created attachment 178165 [details]
Patch

[Mary Wu]

Comment on attachment 178165 [details]
Patch

correct reviewer in log.

[WebKit Review Bot]

Comment on attachment 178165 [details]
Patch

Rejecting attachment 178165 [details] from commit-queue.

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Full output: http://queues.webkit.org/results/15182414

[WebKit Review Bot]

Comment on attachment 178165 [details]
Patch

Clearing flags on attachment: 178165

Committed r136930: <http://trac.webkit.org/changeset/136930>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.