Bug 104069

Summary: [V8] Rename V8DOMWrapper member functions to be more descriptive
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing abarth: commit-queue+

Adam Barth
Reported 2012-12-04 17:25:24 PST
[V8] Rename V8DOMWrapper member functions to be more descriptive
Attachments
Patch (67.16 KB, patch)
2012-12-04 17:26 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (80.76 KB, patch)
2012-12-04 17:32 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (80.87 KB, patch)
2012-12-04 17:35 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (68.33 KB, patch)
2012-12-04 17:37 PST, Adam Barth 		abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-12-04 17:26:37 PST
Created attachment 177617 [details] Patch
Eric Seidel (no email)
Comment 2 2012-12-04 17:31:19 PST
Comment on attachment 177617 [details] Patch You mentioned flipping the name from associateWrapper to associateObjectWithWrapper.
Kentaro Hara
Comment 3 2012-12-04 17:32:00 PST
Comment on attachment 177617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177617&action=review > Source/WebCore/bindings/v8/V8DOMWrapper.h:61 > + static v8::Local<v8::Object> create(v8::Handle<v8::Object> creationContext, WrapperTypeInfo*, void*); V8DOMWrapper::create() sounds like a factory method for a V8DOMWrapper object. I might prefer V8DOMWrapper::createWrapper().
Adam Barth
Comment 4 2012-12-04 17:32:42 PST
Created attachment 177619 [details] Patch for landing
Adam Barth
Comment 5 2012-12-04 17:33:16 PST
Comment on attachment 177619 [details] Patch for landing ok
Adam Barth
Comment 6 2012-12-04 17:35:19 PST
Created attachment 177622 [details] Patch for landing
Adam Barth
Comment 7 2012-12-04 17:37:40 PST
Created attachment 177625 [details] Patch for landing
Adam Barth
Comment 8 2012-12-04 17:41:40 PST
Committed r136605: <http://trac.webkit.org/changeset/136605>
Note You need to log in before you can comment on or make changes to this bug.