Summary: | [Shadow DOM]: Element.pseudo property should be prefixed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominic Cooney <dominicc> | ||||||
Component: | DOM | Assignee: | Dominic Cooney <dominicc> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, cmarcelo, dglazkov, gtk-ews, morrita, ojan, tkent, webcomponents-bugzilla, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 97282 | ||||||||
Attachments: |
|
Description
Dominic Cooney
2012-12-04 16:34:26 PST
Created attachment 177608 [details]
Patch
Comment on attachment 177608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177608&action=review Thanks for the catch! I overlooked this. > Source/WebCore/html/HTMLAttributeNames.in:277 > +x-webkit-pseudo nit: alphabetical order. I think fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html needs to be updated. Comment on attachment 177608 [details] Patch Attachment 177608 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15158081 Looks like I missed a bunch of rebaselines. Will investigate GTK failure. Re: comment 2 - I am keeping the convention of x-webkit-speech and x-webkit-grammar which alphabetize ignoring x-webkit-. (In reply to comment #5) > Re: comment 2 - I am keeping the convention of x-webkit-speech and x-webkit-grammar which alphabetize ignoring x-webkit-. Got it. Comment on attachment 177608 [details] Patch Attachment 177608 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15132751 Comment on attachment 177608 [details] Patch Attachment 177608 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15151354 New failing tests: editing/style/apply-style-atomic.html fast/dom/HTMLMeterElement/meter-element-markup.html fast/dom/HTMLProgressElement/progress-element-markup.html Comment on attachment 177608 [details] Patch Attachment 177608 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15159186 New failing tests: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html editing/style/apply-style-atomic.html fast/dom/HTMLMeterElement/meter-element-markup.html fast/dom/HTMLProgressElement/progress-element-markup.html Comment on attachment 177608 [details] Patch Attachment 177608 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15147437 New failing tests: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html editing/style/apply-style-atomic.html fast/dom/HTMLMeterElement/meter-element-markup.html fast/dom/HTMLProgressElement/progress-element-markup.html Created attachment 177974 [details]
Patch
Comment on attachment 177974 [details]
Patch
Think this is good to go now.
In offline discussion with morrita we concluded to prefix the JavaScript property but not the DOM attribute name.
Comment on attachment 177974 [details] Patch Clearing flags on attachment: 177974 Committed r136913: <http://trac.webkit.org/changeset/136913> All reviewed patches have been landed. Closing bug. |