Bug 104049

Summary: [chromium] Remove hardcoded chromium_*.jar in gyp files
Product: WebKit Reporter: Chris Hopman <cjhopman>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, dglazkov, eric, peter, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Hopman
Reported 2012-12-04 15:15:59 PST
Remove hardcoded chromium_*.jar in gyp files
Attachments
Patch (8.09 KB, patch)
2012-12-04 15:21 PST, Chris Hopman 		no flags
DetailsFormatted DiffDiff
Patch (8.09 KB, patch)
2013-01-15 16:34 PST, Chris Hopman 		no flags
DetailsFormatted DiffDiff
Patch (8.12 KB, patch)
2013-01-16 08:37 PST, Chris Hopman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Hopman
Comment 1 2012-12-04 15:21:21 PST
Created attachment 177583 [details] Patch
Peter Beverloo (cr-android ews)
Comment 2 2012-12-04 18:21:25 PST
Comment on attachment 177583 [details] Patch Attachment 177583 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15132697
Peter Beverloo
Comment 3 2012-12-12 05:54:18 PST
Hi Chris, any idea about the errors?
Chris Hopman
Comment 4 2012-12-12 10:54:58 PST
(In reply to comment #3) > Hi Chris, any idea about the errors? Ah, there was a Chromium change that this required that (I think) wasn't rolled into WebKit until the 5th.
Chris Hopman
Comment 5 2013-01-15 16:34:50 PST
Created attachment 182871 [details] Patch
Chris Hopman
Comment 6 2013-01-15 16:41:26 PST
Comment on attachment 182871 [details] Patch New patch is rebased (though I don't know that anything changed). This change also fixes TestWebKitAPI for Android (as a nice side effect), which has been failing for weeks downstream (but appears to not be running on WebKit buildbots).
Peter Beverloo
Comment 7 2013-01-16 08:33:32 PST
Comment on attachment 182871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182871&action=review Running of the tests has a CL up downstream. Thanks, Chris, I verified that this works, and the change looks good to me with a few minor nits. > Source/WebKit/chromium/ChangeLog:1 > +2013-01-15 Chris Hopman <cjhopman@google.com> Should this be your @chromium.org account? > Source/WebKit/chromium/ChangeLog:3 > + Remove hardcoded chromium_*.jar in gyp files Please update the title to have the [chromium] prefixes, as Darin added.
Chris Hopman
Comment 8 2013-01-16 08:37:09 PST
Created attachment 182991 [details] Patch
Eric Seidel (no email)
Comment 9 2013-01-16 10:35:21 PST
Comment on attachment 182991 [details] Patch rs=me.
WebKit Review Bot
Comment 10 2013-01-16 10:39:13 PST
Comment on attachment 182991 [details] Patch Clearing flags on attachment: 182991 Committed r139895: <http://trac.webkit.org/changeset/139895>
WebKit Review Bot
Comment 11 2013-01-16 10:39:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.