| Summary: | [chromium] Remove hardcoded chromium_*.jar in gyp files | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Hopman <cjhopman> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, darin, dglazkov, eric, peter, peter+ews, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Hopman
2012-12-04 15:15:59 PST
Created attachment 177583 [details]
Patch
Comment on attachment 177583 [details] Patch Attachment 177583 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15132697 Hi Chris, any idea about the errors? (In reply to comment #3) > Hi Chris, any idea about the errors? Ah, there was a Chromium change that this required that (I think) wasn't rolled into WebKit until the 5th. Created attachment 182871 [details]
Patch
Comment on attachment 182871 [details]
Patch
New patch is rebased (though I don't know that anything changed).
This change also fixes TestWebKitAPI for Android (as a nice side effect), which has been failing for weeks downstream (but appears to not be running on WebKit buildbots).
Comment on attachment 182871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182871&action=review Running of the tests has a CL up downstream. Thanks, Chris, I verified that this works, and the change looks good to me with a few minor nits. > Source/WebKit/chromium/ChangeLog:1 > +2013-01-15 Chris Hopman <cjhopman@google.com> Should this be your @chromium.org account? > Source/WebKit/chromium/ChangeLog:3 > + Remove hardcoded chromium_*.jar in gyp files Please update the title to have the [chromium] prefixes, as Darin added. Created attachment 182991 [details]
Patch
Comment on attachment 182991 [details]
Patch
rs=me.
Comment on attachment 182991 [details] Patch Clearing flags on attachment: 182991 Committed r139895: <http://trac.webkit.org/changeset/139895> All reviewed patches have been landed. Closing bug. |