Bug 104041

Summary: [BlackBerry] Keep screen updates suspended until after a viewport resize
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: manyoso, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jakob Petsovits
Reported 2012-12-04 14:04:02 PST
Now that screen and backing store updates can be suspended and resumed separately from each other, we should prevent blits for the whole duration of setViewportSize() and always issue a blit at the end. This would make WebPage::setViewportSize() more robust (no possible way that a blit would end up being performed in a different thread even in case of race conditions) and easier to read/understand.
Attachments
Patch (4.18 KB, patch)
2012-12-04 14:10 PST, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2012-12-04 14:10:17 PST
Created attachment 177554 [details] Patch And also fixes a few FIXMEs that were in here from the initial screen/backingstore split of suspend/resumes.
Adam Treat
Comment 2 2012-12-05 13:12:53 PST
Comment on attachment 177554 [details] Patch LGTM
WebKit Review Bot
Comment 3 2012-12-05 13:38:29 PST
Comment on attachment 177554 [details] Patch Clearing flags on attachment: 177554 Committed r136753: <http://trac.webkit.org/changeset/136753>
WebKit Review Bot
Comment 4 2012-12-05 13:38:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.