Bug 104027

Summary: NodeFilter leaks memory in V8
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED INVALID    
Severity: Normal CC: adamk, burg, dcarney, eric, esprehn, haraken, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 104575    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-12-04 12:21:39 PST
NodeFilter leaks memory in V8
Attachments
Patch (7.06 KB, patch)
2012-12-04 12:23 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-12-04 12:23:33 PST
Created attachment 177525 [details] Patch
Adam Barth
Comment 2 2012-12-04 13:46:52 PST
Comment on attachment 177525 [details] Patch Clearing flags on attachment: 177525 Committed r136559: <http://trac.webkit.org/changeset/136559>
Adam Barth
Comment 3 2012-12-04 13:46:54 PST
All reviewed patches have been landed. Closing bug.
Elliott Sprehn
Comment 4 2012-12-04 13:54:44 PST
Is there a reason you didn't use the hidden property weak ownership stuff from MutationObservers that I added to the code generator?
Elliott Sprehn
Comment 5 2012-12-04 13:56:09 PST
(In reply to comment #4) > Is there a reason you didn't use the hidden property weak ownership stuff from MutationObservers that I added to the code generator? Oh I see, this wasn't a [Callback] in the idl.
Adam Barth
Comment 6 2012-12-04 14:03:36 PST
Yeah, I thought about trying to unify them, but NodeFilter has some goofy quirks we'd need to teach callbacks about.
Eric Seidel (no email)
Comment 7 2012-12-10 10:50:44 PST
Re-opened since this is blocked by bug 104575
Eric Seidel (no email)
Comment 8 2012-12-10 10:51:57 PST
Rolled this out manually in bug 104575.
Note You need to log in before you can comment on or make changes to this bug.